Fixed regression in the add-on repository names (bsc#1175374)

[lslezak]

The Problem

• This is similar fix to Fixed name of the add-on repository (bsc#1175374) yast-packager#533, see that PR for more details
• I do not know when exactly this bug happens and what's the real problem, I found the problematic place by grepping for Pkg.SourceEditSet

Testing

• As metioned above, I could not easily test the bug fix (and it's AutoYaST...)
• But there is an unit test for that so hopefully that's enough
• Either it fixes the problem or we get a bug report with more details later

[coveralls]

Coverage remained the same at 22.35% when pulling 955010f on rename_fix_sp2 into 25b2273 on SLE-15-SP2.

[mvidner]

The fix looks sensible, with reservations that you've already stated.

Since we're changing preferred_name I checked its doc comment: repo "Array" is a lie, it wants a Hash. Can we link to a description what the two parameter hashes look like?

(When I document APIs I like to declare trivial subclasses of Hash just for YARD documentation purposes, but any other way that gets the docs across is fine)

[lslezak]

This is a maintenance update for SP2, I'd keep the changes as small as possible. I'll try improving the docu in master...

[lslezak]

Submitted in https://build.suse.de/request/show/226588