Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh system config after writing yast_config to the system (bsc#1162987) #1051

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Mar 27, 2020

Problem

Network system configuration is cached by YaST the first time it is read, and then it is not refreshed when it is written, thus, some config is not written as it does not see differences between the yast_config and the system_config.

In this case, before setting the dhcp configuration, the DHCLIENT_SET_HOSTNAME is no.

YaST enables it when setting the DHCP configuration based on the control file default as implemented in #564

Then, the option is set to yes in yast_config, it is written to the config file, but it is still cached as no in the system_config. Which means, that if we set it to no in the GUI later (yast_config), it will not be modified because it is the same in yast_config and system_config.

Solution

  • Replace the cached system network config by the written one after writing.

Tests

  • tested manually

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 70.369% when pulling 17fe3b2 on refresh_system_config into bbefa54 on master.

@teclator teclator merged commit 113ed20 into master Mar 27, 2020
@teclator teclator deleted the refresh_system_config branch March 27, 2020 15:55
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #142 successfully finished
✔️ Created OBS submit request #789096

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #79 successfully finished
✔️ Created IBS submit request #214868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants