Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoyast based installation does not seem to respect defined udev rules. #1061

Merged
merged 15 commits into from
Jun 8, 2020

Conversation

teclator
Copy link
Contributor

@teclator teclator commented May 24, 2020

Problem

Udev rules are not refreshed after writting

The InterfacesWriter did not refreshed the written udev rules in case of an autoinstallation as we can see here:

https://github.com/yast/yast-network/pull/1059/files#diff-48ec4731f89821c19dc203da64dc00a5L108

In case of the second stage, or, the first stage with the imported network configuration written before the proposal, then, a rename of the interfaces is needed. Thus, we should distinguish between being at the end of the installation (already chrooted) or not.

Solution

The problem with udev rules handling during installation was already fixed in #1059, as well as other issues. Thus, I have backported some of the commits, at least the relevants to SP2, and adapted the code where it was needed. We have to take into account that in SP3, the idea is to write the network configuration during the first stage by default.

Tests

  • Tested manually
  • Added some unit tests

@coveralls
Copy link

coveralls commented May 24, 2020

Coverage Status

Coverage increased (+0.3%) to 71.058% when pulling 8138955 on autoyast_fixes into 91d9814 on SLE-15-SP2.

Copy link
Member

@mchf mchf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no complains, thanks ;-)

@mchf
Copy link
Member

mchf commented Jun 8, 2020

lgtm

@teclator teclator merged commit b1817a2 into SLE-15-SP2 Jun 8, 2020
@teclator teclator deleted the autoyast_fixes branch June 8, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants