Fix connection_config equality comparison

[teclator]

Problem

Bond configuration is not modified after changing the bond options. For checking changes between configuration we created an alias eql? of the "==" method, but the sub-classes need to define it to in order to call its overridden "==" method.

• https://trello.com/c/wmoYqtac/2184-l3-1178950-changing-bond-details-through-yast-does-not-change-files-on-disk

Solution

Fix the detection of network config changes defining the alias_method :eql? :== in each of the connection config sub-classes that overrides the == method

Manual test without the fix

irb(main):003:0> Yast::Lan.Read(:cache)
=> true
irb(main):004:0> bond0 = Yast::Lan.yast_config.connections.by_name("bond0")
=> #<Y2Network::ConnectionConfig::Bonding:0x00005622102a6498 @id=1, @ip_aliases=[], @bootproto=#<Y2Network::BootProtocol:0x00005622102a63a8 @name="dhcp">, @ip=#<Y2Network::ConnectionConfig::IPConfig:0x00005622102a6308 @address=#<Y2Network::IPAddress:0x00005622102a6290 @address=#<IPAddr: IPv4:0.0.0.0/255.255.255.255>, @prefix=nil>, @id="", @label=nil, @remote_address=nil, @broadcast=nil>, @startmode=#<Y2Network::Startmodes::Auto:0x00005622102a6060 @my_textdomain=["network"], @name="auto">, @description=nil, @ethtool_options=nil, @firewall_zone=nil, @slaves=["eth1", "eth0"], @options="mode=active-backup miimon=300", @interface="bond0", @name="bond0", @lladdress=nil, @hostname=nil, @mtu=nil>
irb(main):005:0> system_bond0 = Yast::Lan.system_config.connections.by_name("bond0")
=> #<Y2Network::ConnectionConfig::Bonding:0x00005622101ae360 @id=1, @ip_aliases=[], @bootproto=#<Y2Network::BootProtocol:0x000056220f826d60 @name="dhcp">, @ip=#<Y2Network::ConnectionConfig::IPConfig:0x00005622101b50c0 @address=#<Y2Network::IPAddress:0x00005622101b5138 @address=#<IPAddr: IPv4:0.0.0.0/255.255.255.255>, @prefix=nil>, @id="", @label=nil, @remote_address=nil, @broadcast=nil>, @startmode=#<Y2Network::Startmodes::Auto:0x00005622101b4ee0 @my_textdomain=["network"], @name="auto">, @description=nil, @ethtool_options=nil, @firewall_zone=nil, @slaves=["eth1", "eth0"], @options="mode=active-backup miimon=300", @interface="bond0", @name="bond0", @lladdress=nil, @hostname=nil, @mtu=nil>
irb(main):006:0> bond0.eql?(system_bond0)
=> true
irb(main):007:0> bond0.options
=> "mode=active-backup miimon=300"
irb(main):008:0> bond0.options = "mode=active-backup miimon=100"
=> "mode=active-backup miimon=100"
irb(main):009:0> bond0.eql?(system_bond0)
=> true
irb(main):010:0> bond0 == system_bond0
=> false
irb(main):011:0> Yast::Lan.yast_config == Yast::Lan.system_config
=> true

Manual test with the fix

irb(main):004:0> bond0 = Yast::Lan.yast_config.connections.by_name("bond0")
=> #<Y2Network::ConnectionConfig::Bonding:0x000056477483cb58 @id=1, @ip_aliases=[], @bootproto=#<Y2Network::BootProtocol:0x000056477483ca68 @name="dhcp">, @ip=#<Y2Network::ConnectionConfig::IPConfig:0x000056477483c9c8 @address=#<Y2Network::IPAddress:0x000056477483c950 @address=#<IPAddr: IPv4:0.0.0.0/255.255.255.255>, @prefix=nil>, @id="", @label=nil, @remote_address=nil, @broadcast=nil>, @startmode=#<Y2Network::Startmodes::Auto:0x000056477483c720 @my_textdomain=["network"], @name="auto">, @description=nil, @ethtool_options=nil, @firewall_zone=nil, @slaves=["eth1", "eth0"], @options="mode=active-backup miimon=300", @interface="bond0", @name="bond0", @lladdress=nil, @hostname=nil, @mtu=nil>
irb(main):005:0> system_bond0 = Yast::Lan.system_config.connections.by_name("bond0")
=> #<Y2Network::ConnectionConfig::Bonding:0x00005647746150c8 @id=1, @ip_aliases=[], @bootproto=#<Y2Network::BootProtocol:0x0000564773ffae40 @name="dhcp">, @ip=#<Y2Network::ConnectionConfig::IPConfig:0x000056477461d098 @address=#<Y2Network::IPAddress:0x000056477461d110 @address=#<IPAddr: IPv4:0.0.0.0/255.255.255.255>, @prefix=nil>, @id="", @label=nil, @remote_address=nil, @broadcast=nil>, @startmode=#<Y2Network::Startmodes::Auto:0x000056477461ceb8 @my_textdomain=["network"], @name="auto">, @description=nil, @ethtool_options=nil, @firewall_zone=nil, @slaves=["eth1", "eth0"], @options="mode=active-backup miimon=300", @interface="bond0", @name="bond0", @lladdress=nil, @hostname=nil, @mtu=nil>
irb(main):006:0> bond0.eql?(system_bond0)
=> true
irb(main):007:0> bond0.options
=> "mode=active-backup miimon=300"
irb(main):008:0> bond0.options = "mode=active-backup miimon=100"
=> "mode=active-backup miimon=100"
irb(main):009:0> bond0.eql?(system_bond0)
=> false
irb(main):010:0> bond0 == system_bond0
=> false
irb(main):011:0> Yast::Lan.yast_config == Yast::Lan.system_config
=> false