Fixed openQA issue #316
Merged
Fixed openQA issue #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1229,7 +1229,7 @@ def BuildBondIndex | |||
| deep_copy(index) | |||
| end | |||
|
|
|||
| def startmode_overview | |||
| def startmode_overview(item_id) | |||
There was a problem hiding this comment.
@param item_id [Integer] a key for {#Items}
I keep forgetting which API uses numbers and which uses the kernel names.
There was a problem hiding this comment.
NTH: Consider adding this to the many other methods which are missing an explanation for item_id / itemId.
Network heavilly accesses NetworkInterfaces' internal structurei and state.i This time it stopped working due to fixes done elsewhere.
|
LGTM |
|
Thanks for reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bnc#930448