Report error when 2nd stage is disabled (bsc#1046198) #524
Conversation
lslezak
commented
Jun 29, 2017
•
lslezak
commented
- Report a warning when the imported AY settings require the seconds stage but it is disabled in the profile
- Fix for https://bugzilla.suse.com/show_bug.cgi?id=1046198
- Tested with the profile attached at in the bug report
| @@ -479,6 +482,21 @@ def Import(settings) | |||
|
|
|||
| @nameservers = Builtins.eval(Ops.get_list(settings, "nameservers", [])) | |||
| @searchlist = Builtins.eval(Ops.get_list(settings, "searchlist", [])) | |||
|
|
|||
| # check for AY unsupported scenarios, the name servers and the search domains | |||
| # are written in the 2nd stage, if is disabled then it cannot work (bsc#1046198) | |||
There was a problem hiding this comment.
So, we're fixing a bug which is not a bug. Somebody tried to use the module by an unsupported way and we'll take care of it.
In my POV the issue should be closed as invalid. Instead of adding a check for one of several unsupported cases we should improve documentation for SP3 to make more obvious what is and is not supported.
There was a problem hiding this comment.
Yes, I agree that it's not a real bug. But on the other hand nobody reads the documentation, if we print an error we might get false bug reports...
The tricky part is that the profile validates, and unless you know this limitation (or read the documentation) there is no way to find out that the profile is not correct.
There was a problem hiding this comment.
I have the same opinion as Lada here. Just inform the user. But I would take a warning or info level.
|
"The Import is called twice during installation, is it OK to display the error twice? Or should I add some logic so it is displayed only once?" |
lslezak
force-pushed
the
ay_dns_check
branch
2 times, most recently
from
aba879f
to
a1a6e90
Compare
lslezak
changed the title
* Report error when 2nd stage is disabled (bsc#1046198) * Code review fixes * Added unit test * Check more settings, use more generic message * Changes
* Report error when 2nd stage is disabled (bsc#1046198) * Code review fixes * Added unit test * Check more settings, use more generic message * Changes
