-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better English in the README. #130
Conversation
Cannot be merged |
Conflicts: README.md
I fix mergability. |
As for the review, the English is obviously perfect ;-) so IMHO someone should check that I did not accidentally change the meaning. |
to be called from component system. Clients can be called via WFM (see below ) | ||
and modules provide interface via publish method, where is specified type. | ||
|
||
The connection to the [YaST component system][arch] has two parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it correct link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A working one is https://github.com/yast/yast.github.io/blob/master/doc/architecture.md but the one preferred is probably https://yastgithubio.readthedocs.org/en/latest/architecture/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, preferred one is better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, used that one.
Updated. |
great, LGTM |
To see the actual changes better, run locally
@jreidinger Thank you for the README! To proofread it, I had to read it ;-) and it is good!