Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better English in the README. #130

Merged
merged 3 commits into from
Nov 26, 2014
Merged

Better English in the README. #130

merged 3 commits into from
Nov 26, 2014

Conversation

mvidner
Copy link
Member

@mvidner mvidner commented Oct 17, 2014

To see the actual changes better, run locally

git diff --color-words=[A-Za-z] master..better_readme

@jreidinger Thank you for the README! To proofread it, I had to read it ;-) and it is good!

@kobliha
Copy link
Member

kobliha commented Oct 30, 2014

Cannot be merged

@jreidinger
Copy link
Member

I fix mergability.

@mvidner
Copy link
Member Author

mvidner commented Nov 3, 2014

As for the review, the English is obviously perfect ;-) so IMHO someone should check that I did not accidentally change the meaning.

to be called from component system. Clients can be called via WFM (see below )
and modules provide interface via publish method, where is specified type.

The connection to the [YaST component system][arch] has two parts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it correct link?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, preferred one is better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, used that one.

@mvidner
Copy link
Member Author

mvidner commented Nov 26, 2014

Updated.

@jreidinger
Copy link
Member

great, LGTM

mvidner added a commit that referenced this pull request Nov 26, 2014
Better English in the README.
@mvidner mvidner merged commit ef1d3c8 into master Nov 26, 2014
@mvidner mvidner deleted the better_readme branch November 26, 2014 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants