Correct the schema #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
approved these changes
May 27, 2020
jreidinger
reviewed
May 27, 2020
| @@ -481,6 +484,6 @@ samba_options = element options { | |||
| MAP, | |||
| element option { MAP, samba_option_key, samba_option_val? }* | |||
| } | |||
| share = element share { (STRING | y2_share)* } | |||
| share = element share { (text | y2_share)* } | |||
There was a problem hiding this comment.
this channge looks a bit strage. Does it mean that type string is not allowed here?
For the 'disabled' element, jing would say: samba-server.rng:53:48: error: duplicate attribute "type" from namespace "http://www.suse.com/1.0/configns" 'accounts' was not causing problems, just a cleanup
jing would say: samba-server.rng:2249:27: error: a group of attributes must not be repeatable (section 7.1 of the RELAX NG specification requires that the simplified XML form of the schema not contain any elements matching the path oneOrMore//group//attribute) This part of the schema looks fishy (as do other parts) but let's just get over the correctness part now.
|
✔️ Public Jenkins job #21 successfully finished |
|
✔️ Internal Jenkins job #10 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes that we made in #80 turned out to make the schema incorrect.
We did not know it because we had no check for schema correctness, but it is coming: yast/yast-schema#76