Fixed issue where yast2-vpn breaks with strongswan #22
Conversation
|
Changes have been merged into SLE 15 SP5 |
| Service.Enable("strongswan") | ||
| if !(Service.Active("strongswan") ? Service.Restart("strongswan") : Service.Start("strongswan")) | ||
| Service.Enable("strongswan-starter") | ||
| if !(Service.Active("ipsec") ? Service.Restart("ipsec") : Service.Start("ipsec")) |
There was a problem hiding this comment.
IIRC restarting a stopped service should be the same as starting it...
There was a problem hiding this comment.
yes, it is same. restart = stop + start (doesn't care if it's already stopped)
There was a problem hiding this comment.
So, are we gonna change this to
| if !(Service.Active("ipsec") ? Service.Restart("ipsec") : Service.Start("ipsec")) | |
| Service.Restart("ipsec") |
or simply go ahead as it is now?
I'm asking in order to move it forward. Thanks!
There was a problem hiding this comment.
Well, I did not write the original code, I just changed it to point to correct strongswan service file. @dgdavid The change you suggested makes sense but I'm not sure if it'll cause any regressions in the yast2-vpn. There is green signal from me to go ahead as I've tested and it works. I suggest that if such change needs to be done it should done by the maintainer of yast2-vpn module.
|
✔️ Public Jenkins job #23 successfully finished |
|
✔️ Internal Jenkins job #17 successfully finished |
Problem
Short description of the original problem.
yast2-vpn is currently broken with strongswan packages in SLE15 (all SPs) and Leap15.x + Tumbleweed
strongswan version < 5.8.0 used strongswan.service to use with ipsec interface with yast uses. Later versions
have moved to use strongswan-starter.service to use ipsec and strongswan.service is used for swanctl interface
Thus, with newer versions yast is still using the older systemd service file and causing breakage.
https://bugzilla.suse.com/show_bug.cgi?id=1176735
Solution
Short description of the fix.
Fix has been submitted to SLE15 (all SPs) + Factory --> https://build.opensuse.org/request/show/1077377
merging with the codestreams might take some time
but yast2-vpn needs to call the correct systemd service to work properly
Testing
Tested manually with the changes and yast2-vpn module is working correctly