Add missing require clause (bsc#1160362)

[ancorgs]

See https://bugzilla.suse.com/show_bug.cgi?id=1160362 for details.

Some things have changed in the ProductReader class recently. We don't test the Live Installation (is not a supported scenario), but it looks like it follows a different workflow that ends up with an exception because ProductReader contains a call to Y2Packager::ProductControlProduct.products bit it does not require y2packager/product_control_product.

Likely, in the normal workflow it works by pure luck (because some other class requires y2packager/product_control_product).

This pull request adds the missing require together with a smoke test to prove it was indeed missing.

If fact, the whole situation is even worse at this moment. The current code looks like this:

if Yast::Stage.initial && Y2Packager::MediumType.online? && !force_repos
  return Y2Packager::ProductControlProduct.products.each_with_object([]) {..}
end

Which means that there is another missing "require" for Y2Packager::MediumType. But that's harder to fix and, thus, I'm leaving it out of the scope of this pull request. That class lives in yast2-packager, not in yast2.rpm. To achieve a 100% correct solution, the file (and all its dependencies) should be moved. This is currently not failing (again, by pure luck), so we can ignore the problem for the time being.

[coveralls]

Coverage increased (+0.005%) to 30.016% when pulling 2ed00bb on ancorgs:missing_require into d42204c on yast:master.

[lslezak]

LGTM, thanks for the test!

(And yes, that other missing require is not nice... 😟 )

[yast-bot]

✔️ Public Jenkins job #165 successfully finished
✔️ Created OBS submit request #762184

[lslezak]

Thanks!

[yast-bot]

✔️ Internal Jenkins job #63 successfully finished
✔️ Created IBS submit request #208999