Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLE-15-SP3] Discourage the use of old URL modules #1190

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented Jul 26, 2021

As suggested during the review of https://trello.com/c/BnMnGsu9/ (internal link), point developers to the right tools for dealing with (libzypp)URLs.

It mentions not only the URI Ruby standard module, but also the recently added Y2Packager::ZyppUrl (see #1071), which allows dealing with libzypp URLs.

@dgdavid dgdavid changed the base branch from master to SLE-15-SP3 July 26, 2021 15:16
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgdavid dgdavid force-pushed the discourages-old-url-modules branch from aa10409 to 6cc3fa9 Compare July 26, 2021 15:25
@dgdavid dgdavid changed the title Discourage the use of old modules for dealing with URLs [SLE-15-SP3] Discourage the use of old modules for dealing with URLs Jul 26, 2021
@dgdavid dgdavid changed the title [SLE-15-SP3] Discourage the use of old modules for dealing with URLs [SLE-15-SP3] Discourage the use of old URL modules Jul 26, 2021
@coveralls
Copy link

coveralls commented Jul 26, 2021

Coverage Status

Coverage remained the same at 40.53% when pulling 6cc3fa9 on discourages-old-url-modules into d018814 on SLE-15-SP3.

@dgdavid dgdavid merged commit 40bfacf into SLE-15-SP3 Jul 26, 2021
@dgdavid dgdavid deleted the discourages-old-url-modules branch July 26, 2021 15:28
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #2 successfully finished
✔️ Created IBS submit request #246979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants