Added RelURL class (jsc#SLE-22669) #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Dec 14, 2021
| # in an installed system. | ||
| def self.from_installation_repository(rel_url) | ||
| base_url = Yast::InstURL.installInf2Url("") | ||
| new(base_url, rel_url) |
There was a problem hiding this comment.
what will happen if nont relative url is called?
There was a problem hiding this comment.
The result will be this non-relative URL. The caller is responsible to use a relative URL to make it work properly.
jreidinger
reviewed
Dec 14, 2021
jreidinger
reviewed
Dec 14, 2021
| # it creates a copy of the input object and pre-processes the | ||
| # "file://" and "relurl://" URLs | ||
| def import_url(url) | ||
| ret = URI(url).dup |
There was a problem hiding this comment.
how it handles exception from URI?
There was a problem hiding this comment.
No handling, they will just pass through. https://github.com/yast/yast-yast2/pull/1215/files#diff-89f24a21ba7c6b66736e8891b6fc08a235e2ef35a6d11e39fc5ee3c076b1ab38R47-R55
jreidinger
reviewed
Dec 14, 2021
jreidinger
reviewed
Dec 14, 2021
jreidinger
reviewed
Dec 14, 2021
jreidinger
approved these changes
Dec 15, 2021
|
✔️ Public Jenkins job #336 successfully finished |
|
❌ Internal Jenkins job #172 failed |
|
❌ Internal Jenkins job #173 failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
relurl://URLsDetails
../)~with the home directory path on the local system which is not what you would expect in URLs.Testing