Use Package instead of PackageSystem
#1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
force-pushed
the
use-package
branch
from
f1274e8
to
6a7559d
Compare
dgdavid
approved these changes
Jan 25, 2022
jreidinger
reviewed
Jan 25, 2022
| log.info "CheckAndInstallPackages -> #{@needed_packages_installed}" | ||
| else | ||
| @needed_packages_installed = PackageSystem.Installed(@FIREWALL_PACKAGE) | ||
| @needed_packages_installed = Package.Installed(@FIREWALL_PACKAGE) |
There was a problem hiding this comment.
good example that we should finally clean susefirewall, as it is dead technology and we use only firewalld.
There was a problem hiding this comment.
You are right, but I do not plan to do it in this PR.
jreidinger
reviewed
Jan 25, 2022
| @@ -657,15 +657,15 @@ sub UnquoteString { | |||
| sub Init { | |||
| if (Mode->test ()) { | |||
| $package_installed = 1; | |||
| y2milestone("TestMode -> PackageSystem->Installed: ", $package_installed); | |||
| y2milestone("TestMode -> Package->Installed: ", $package_installed); | |||
There was a problem hiding this comment.
dead code. old testsuite is dead and so mode->test
jreidinger
reviewed
Jan 25, 2022
jreidinger
approved these changes
Jan 26, 2022
|
✔️ Public Jenkins job #354 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to
PackageandPackageSystemchanges. See #1219 for further information.