do not strip trailing white space in XML elements (bsc#1195910) #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Feb 16, 2022
| # Do NOT strip trailing white space in CDATA blocks. Maybe people put | ||
| # it intentionally there (bsc#1195910). | ||
| text_nodes = node.xpath("text()") | ||
| text = text_nodes.map { |n| n.cdata? ? n.content.lstrip : n.content.strip }.join |
There was a problem hiding this comment.
is there reason for that lstrip in cdata? I expect it should be as it is
There was a problem hiding this comment.
You want to strip leading newlines in scripts.
jreidinger
requested changes
Feb 16, 2022
|
replaced by #1243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Surrounding white space in some elements may be desired. Like in scripts or other file content. Be more careful when removing it.
The catch
The AutoYaST profile is processed by YaST to construct the final profile. It's written, modified by scripts, then read again, for example. Ensure that during this processing the CDATA 'attribute' to elements is not lost.
Solution
Strip leading white space when reading XML CDATA blocks. And create CDATA blocks when generating XML if an element contains trailing white space.
Note
Why not also keeping leading white space? - It's common to have a leading newline in
scriptsections. They must be removed.