Count test coverage more accurately #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The run method is normally needed, but the test just pays attention to the event_loop defined in the mixin.
|
LGTM, just make rubocop happy: https://travis-ci.org/yast/yast-yast2/builds/103880372#L563 |
Bootloader::ProposalClient, the only subclass so far, did not need it because only some kinds of proposals ever call write.
mvidner
force-pushed
the
dont-cover-tests
branch
from
8db49a0
to
fbd2309
Compare
|
LGTM |
|
|
||
| def write | ||
| # doing nothing is OK. or is it? clarify the API, the docs, actual usage! | ||
| end |
There was a problem hiding this comment.
I worry it is not OK. If you really call it with write, then you expect it do something.
There was a problem hiding this comment.
so possible to overlook bugs. Actual usage is without write, only in very specific modules like used to be network or cio proposal use it as it keep value, so finish client call proposal client with write.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also fix an API bug in the process; need to verify that the fix is harmless
Coverage goes down from 56% to 45%, yay!