-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Build ruby-lint definitions #480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/YorickPeterse/ruby-lint Needs the `constant_paths` feature, unreleased as of 2.2.0
almost, except for systemd_*.rb
Companion to
(not deduplicated yet, TODO) |
mvidner
added a commit
to mvidner/ruby-lint-definitions-yast
that referenced
this pull request
Jun 29, 2016
except they do not work, because they provide Yast::FooClass but not Yast::Foo (instead it is Yast::FooClass::Foo because of whatever bug) oh, and they repeat the included Yast namespace all the time, instead of just referencing it Generated with yast/yast-yast2#480
mvidner
added a commit
to mvidner/ruby-lint-definitions-yast
that referenced
this pull request
Jun 29, 2016
just the version comment changed. generated with yast/yast-yast2#480 (yes, yast2, not its own rpm)
the errors remain but at least they say undefined method ContinueCancel on Popup instead of undefined method ContinueCancel on an instance of Yast or
ruby-lint is still too broken to be deployed. If I manage to fix it (or a subset of it) then I revive this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.