Use full type detection when building device cache #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read used type detection based on ifcfg content before. The user can easily get confused when having e.g. bridge over wlan in such case. Bcs the device is cached as wlan when type is detected according ifcfg but full detection reports that as bridge.
mchf
force-pushed
the
bnc956755-type-detection
branch
from
743c1bd
to
c8163b0
Compare
jreidinger
approved these changes
Nov 28, 2017
|
thanks for the review |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #527
The fix replaces ifcfg only type detection by full type detection when building device config cache. type detection based on ifcfg can differ from the reality mainly in situations when the config file contains some unexpected option. E.g. when user leaves
ETHERDEVICE=eth0in eth device's config file then ifcfg based type detection can report typevlanbut correct one iseth.