Skip to content

Conversation

1NepuNep1
Copy link
Collaborator

@1NepuNep1 1NepuNep1 commented Oct 7, 2025

Related to #4

@1NepuNep1 1NepuNep1 requested a review from Copilot October 7, 2025 17:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds list support for YDB engine in sqlc, extending parameter handling and type conversion capabilities.

  • Enhanced YDB parameter handling for list/array types with new builder methods and template logic
  • Added type conversion support for YDB composite types (list, tuple, struct, variant)
  • Refactored code generation to handle complex container types that require manual parameter passing

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
internal/sql/rewrite/parameters.go Adds YDB-specific parameter replacement logic
internal/engine/ydb/convert.go Implements YDB type conversion for lists, tuples, and other composite types
internal/codegen/golang/ydb_type.go Updates array type handling for YDB columns
internal/codegen/golang/templates/ydb-go-sdk/queryCode.tmpl Modifies templates to support complex container parameters
internal/codegen/golang/query.go Adds new methods for YDB parameter building and complex type detection
examples/authors/ydb/query.sql.go Shows updated generated code with new parameter builder pattern

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@1NepuNep1 1NepuNep1 changed the title List support Containers support in paramBuilder Oct 7, 2025
@1NepuNep1 1NepuNep1 changed the title Containers support in paramBuilder Containers support in ydb.ParamsBuilder() Oct 7, 2025
@1NepuNep1 1NepuNep1 changed the title Containers support in ydb.ParamsBuilder() Ydb-go-sdk codegen: Containers support in ydb.ParamsBuilder() Oct 7, 2025
@1NepuNep1 1NepuNep1 requested a review from Copilot October 7, 2025 17:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@1NepuNep1 1NepuNep1 requested a review from Copilot October 7, 2025 17:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@1NepuNep1 1NepuNep1 merged commit 816eda8 into ydb-platform:ydb Oct 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants