-
Notifications
You must be signed in to change notification settings - Fork 1
Ydb-go-sdk codegen: Containers support in ydb.ParamsBuilder() #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds list support for YDB engine in sqlc, extending parameter handling and type conversion capabilities.
- Enhanced YDB parameter handling for list/array types with new builder methods and template logic
- Added type conversion support for YDB composite types (list, tuple, struct, variant)
- Refactored code generation to handle complex container types that require manual parameter passing
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
internal/sql/rewrite/parameters.go | Adds YDB-specific parameter replacement logic |
internal/engine/ydb/convert.go | Implements YDB type conversion for lists, tuples, and other composite types |
internal/codegen/golang/ydb_type.go | Updates array type handling for YDB columns |
internal/codegen/golang/templates/ydb-go-sdk/queryCode.tmpl | Modifies templates to support complex container parameters |
internal/codegen/golang/query.go | Adds new methods for YDB parameter building and complex type detection |
examples/authors/ydb/query.sql.go | Shows updated generated code with new parameter builder pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Related to #4