feat(Configs): add info about full config #2921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
artemmufazalov,
astandrik and
adameat
as code owners
artemmufazalov
previously approved these changes
Sep 26, 2025
| tabs = tabs.filter((tab) => tab.id !== clusterTabsIds.events); | ||
| skippedTabs.push(clusterTabsIds.events); | ||
| } | ||
| if (!isViewerUser) { |
There was a problem hiding this comment.
Why don't you also check capabilities here?
There was a problem hiding this comment.
I'll clarify this on Monday!
|
I had to migrate from YDBSyntaxHighlighter to MonacoEditor, as the previous solution caused the interface to freeze when working with large configs. |
Raubzeug
commented
Sep 26, 2025
| }; | ||
|
|
||
| return ( | ||
| <TableWithControlsLayout fullHeight className={b(null, className)}> |
There was a problem hiding this comment.
I use here TableWithControlsLayout cause it perfectly fits. I'm going to rename TableWithControlsLayout -> SectionWithControlsLayout so it may be used not only with tables, but with whatever content.
| tabs = tabs.filter((tab) => tab.id !== clusterTabsIds.events); | ||
| skippedTabs.push(clusterTabsIds.events); | ||
| } | ||
| if (!isViewerUser) { |
There was a problem hiding this comment.
I'll clarify this on Monday!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2867
stand:
Cluster page
Node page
Database page
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.61 MB | Main: 85.37 MB
Diff: +0.24 MB (0.28%)
ℹ️ CI Information