Skip to content

Conversation

asmyasnikov
Copy link
Member

@asmyasnikov asmyasnikov commented May 6, 2022

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@github-actions
Copy link

github-actions bot commented May 6, 2022

API Changes

github.com/ydb-platform/ydb-go-sdk/v3/table/types

compatible changes

IntervalValueFromMicroseconds: added
NullableIntervalValueFromMicroseconds: added

summary

Base version: v3.26.9-0.20220602102142-819b51c333da (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.26.8.

@asmyasnikov asmyasnikov changed the title IntervalValueFromDuration2 Interval <-> time.Duration fix May 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #251 (a2f9e34) into master (afee622) will decrease coverage by 0.10%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   54.41%   54.30%   -0.11%     
==========================================
  Files         131      131              
  Lines       15340    15346       +6     
==========================================
- Hits         8347     8334      -13     
- Misses       6456     6472      +16     
- Partials      537      540       +3     
Flag Coverage Δ
1.14.x 26.16% <83.33%> (-0.02%) ⬇️
1.15.x 26.16% <83.33%> (-0.02%) ⬇️
1.16.x 26.16% <83.33%> (-0.02%) ⬇️
1.17.x 54.30% <62.50%> (-0.11%) ⬇️
1.18.x 26.16% <83.33%> (-0.02%) ⬇️
connection 11.94% <0.00%> (-0.01%) ⬇️
discovery 11.46% <0.00%> (-0.05%) ⬇️
e2e 44.01% <0.00%> (-0.16%) ⬇️
integration 44.01% <0.00%> (-0.16%) ⬇️
macOS-latest 26.16% <83.33%> (-0.02%) ⬇️
ratelimiter 14.02% <0.00%> (-0.01%) ⬇️
scripting 14.43% <0.00%> (-0.01%) ⬇️
table 38.70% <0.00%> (-0.12%) ⬇️
ubuntu-latest 54.30% <62.50%> (-0.11%) ⬇️
unit 26.16% <83.33%> (-0.02%) ⬇️
windows-latest 26.16% <83.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/table/scanner/scan_raw.go 1.03% <0.00%> (ø)
internal/timeutil/time.go 16.66% <0.00%> (ø)
internal/value/value.go 47.80% <ø> (ø)
internal/table/scanner/scanner.go 38.16% <66.66%> (ø)
table/types/value.go 77.00% <100.00%> (-1.18%) ⬇️
testutil/timeutil/timeutil.go 24.00% <0.00%> (-16.00%) ⬇️
internal/xnet/xnet.go 79.54% <0.00%> (-13.64%) ⬇️
internal/table/client.go 87.53% <0.00%> (-0.46%) ⬇️
internal/table/session.go 74.74% <0.00%> (-0.23%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afee622...a2f9e34. Read the comment docs.

@asmyasnikov asmyasnikov force-pushed the interval branch 6 times, most recently from a94553e to 839f0fd Compare May 18, 2022 12:06
…[WithDefaults,Named]()`

* Fixed bug with make ydb value from `time.Duration` in `types.IntervalValueFromDuration(d)`
@asmyasnikov asmyasnikov merged commit a8cde6f into master Jun 6, 2022
@asmyasnikov asmyasnikov deleted the interval branch June 6, 2022 06:30
@rekby rekby linked an issue Jun 16, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: time.Duration wrong stores and reads with ydb type Interval
2 participants