Skip to content

Conversation

asmyasnikov
Copy link
Member

@asmyasnikov asmyasnikov commented May 20, 2022

…guous understanding of package mission
+

  • Fixed data race on session stream queries

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #210

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #262 (f7dd6ff) into master (d25adf4) will decrease coverage by 16.65%.
The diff coverage is 58.82%.

@@             Coverage Diff             @@
##           master     #262       +/-   ##
===========================================
- Coverage   55.27%   38.61%   -16.66%     
===========================================
  Files         132      132               
  Lines       15753    15753               
===========================================
- Hits         8707     6083     -2624     
- Misses       6483     9229     +2746     
+ Partials      563      441      -122     
Flag Coverage Δ
1.14.x 26.69% <38.58%> (+0.07%) ⬆️
1.15.x 26.62% <38.58%> (ø)
1.16.x 26.62% <38.58%> (ø)
1.17.x 38.55% <58.82%> (-16.72%) ⬇️
1.18.x 26.62% <38.58%> (ø)
connection 12.55% <26.47%> (ø)
discovery 11.84% <19.11%> (ø)
e2e 20.49% <30.14%> (-24.24%) ⬇️
integration 20.49% <30.14%> (-24.24%) ⬇️
macOS-latest 26.62% <38.58%> (ø)
ratelimiter 14.57% <25.73%> (ø)
scripting 15.00% <26.47%> (ø)
table ?
ubuntu-latest 38.55% <58.82%> (-16.72%) ⬇️
unit 26.69% <38.58%> (+0.07%) ⬆️
windows-latest 26.69% <38.58%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/balancer/ctx.go 100.00% <ø> (ø)
internal/balancer/local_dc.go 82.40% <ø> (ø)
internal/table/client.go 85.25% <ø> (-4.11%) ⬇️
log/driver.go 39.48% <0.00%> (-15.03%) ⬇️
testutil/driver.go 9.65% <0.00%> (ø)
internal/table/session.go 42.97% <43.75%> (-31.78%) ⬇️
internal/balancer/balancer.go 71.06% <64.91%> (ø)
connection.go 71.54% <75.00%> (-13.83%) ⬇️
balancers/balancers.go 76.59% <82.35%> (ø)
balancers/config.go 95.08% <100.00%> (ø)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d25adf4...f7dd6ff. Read the comment docs.

@github-actions
Copy link

API Changes

summary

Base version: v3.25.4-0.20220520095824-d25adf49a4b3 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.25.3.

@asmyasnikov asmyasnikov merged commit be339ca into master May 20, 2022
@asmyasnikov asmyasnikov deleted the rename-router-to-balancer branch May 20, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants