Skip to content

Add root_certificates argument for connection #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ydb_dbapi/connections.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ def __init__(
credentials: ydb.Credentials | dict | str | None = None,
ydb_session_pool: SessionPool | AsyncSessionPool | None = None,
root_certificates_path: str | None = None,
root_certificates: str | None = None,
**kwargs: dict,
) -> None:
protocol = protocol if protocol else "grpc"
Expand All @@ -97,14 +98,17 @@ def __init__(
self._session_pool._query_client_settings = settings
self._driver = self._session_pool._driver
else:
if root_certificates is None:
root_certificates = ydb.load_ydb_root_certificate(
root_certificates_path
)

driver_config = ydb.DriverConfig(
endpoint=self.endpoint,
database=self.database,
credentials=self.credentials,
query_client_settings=self._get_client_settings(),
root_certificates=ydb.load_ydb_root_certificate(
root_certificates_path
),
root_certificates=root_certificates,
)
self._driver = self._driver_cls(driver_config)
self._session_pool = self._pool_cls(self._driver, size=5)
Expand Down Expand Up @@ -181,6 +185,7 @@ def __init__(
credentials: ydb.Credentials | None = None,
ydb_session_pool: SessionPool | AsyncSessionPool | None = None,
root_certificates_path: str | None = None,
root_certificates: str | None = None,
**kwargs: dict,
) -> None:
super().__init__(
Expand All @@ -192,6 +197,7 @@ def __init__(
credentials=credentials,
ydb_session_pool=ydb_session_pool,
root_certificates_path=root_certificates_path,
root_certificates=root_certificates,
**kwargs,
)
self._current_cursor: Cursor | None = None
Expand Down Expand Up @@ -369,6 +375,7 @@ def __init__(
credentials: ydb.Credentials | None = None,
ydb_session_pool: SessionPool | AsyncSessionPool | None = None,
root_certificates_path: str | None = None,
root_certificates: str | None = None,
**kwargs: dict,
) -> None:
super().__init__(
Expand All @@ -380,6 +387,7 @@ def __init__(
credentials=credentials,
ydb_session_pool=ydb_session_pool,
root_certificates_path=root_certificates_path,
root_certificates=root_certificates,
**kwargs,
)
self._current_cursor: AsyncCursor | None = None
Expand Down