Added functions for check column table type table of any type of sche… #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🌋 Here are results of SLO test for python-sync: |
Valeria1235
approved these changes
Aug 24, 2023
Valeria1235
reviewed
Aug 24, 2023
| :return: True if scheme entry is a table and False otherwise | ||
| :return: True if scheme entry is a row table and False otherwise (same as is_row_table) | ||
| """ | ||
| return entry == SchemeEntryType.TABLE |
There was a problem hiding this comment.
should use is with enums
ydb/scheme.py
Outdated
| :param entry: A scheme entry to check | ||
| :return: True if scheme entry is table (independent of table type) and False otherwise | ||
| """ | ||
| return entry in [SchemeEntryType.TABLE, SchemeEntryType.COLUMN_TABLE] |
There was a problem hiding this comment.
better is tuple or set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me entry
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information