You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not for changelog (changelog entry is not required)
Additional information
We checked for volatile tx too early, with uncommitted writes missing from datashardTxs, which caused transaction to run as non-volatile even when volatile transactions are enabled. This patch changes BuildDatashardTxs to prepare all basic transaction bodies first, before deciding whether it should be volatile, and finally filling sending/receiving shard sets when needed.
⚪ 2024-03-06 12:37:48 UTC Pre-commit check for 40f1d23 has started.
⚪ 2024-03-06 12:37:50 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-06 12:40:01 UTC Build successful.
⚪ 2024-03-06 12:40:11 UTC Tests are running...
🔴 2024-03-06 14:17:24 UTC Some tests failed, follow the links below.
⚪ 2024-03-06 12:42:32 UTC Pre-commit check for 40f1d23 has started.
⚪ 2024-03-06 12:42:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 12:44:56 UTC Build successful.
⚪ 2024-03-06 12:45:10 UTC Tests are running...
🔴 2024-03-06 14:02:01 UTC Some tests failed, follow the links below.
⚪ 2024-03-06 12:45:37 UTC Pre-commit check for 40f1d23 has started.
⚪ 2024-03-06 12:45:38 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-06 12:47:47 UTC Build successful.
⚪ 2024-03-06 20:51:00 UTC Pre-commit check for e886620 has started.
⚪ 2024-03-06 20:51:03 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-06 21:01:29 UTC Build successful.
⚪ 2024-03-06 20:51:52 UTC Pre-commit check for e886620 has started.
⚪ 2024-03-06 20:51:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 20:54:46 UTC Build successful.
⚪ 2024-03-06 20:55:03 UTC Tests are running...
🔴 2024-03-06 22:25:11 UTC Some tests failed, follow the links below.
⚪ 2024-03-06 20:52:12 UTC Pre-commit check for e886620 has started.
⚪ 2024-03-06 20:52:14 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-06 20:55:27 UTC Build successful.
⚪ 2024-03-06 20:55:39 UTC Tests are running...
🔴 2024-03-06 22:37:10 UTC Some tests failed, follow the links below.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snaury
force-pushed
the
fix-2504-volatile-with-uncommitted-changes
branch
from
Changelog entry
...
Changelog category
Additional information
We checked for volatile tx too early, with uncommitted writes missing from datashardTxs, which caused transaction to run as non-volatile even when volatile transactions are enabled. This patch changes BuildDatashardTxs to prepare all basic transaction bodies first, before deciding whether it should be volatile, and finally filling sending/receiving shard sets when needed.
Fixes #2504.