Fix missing locks on read iterator empty result elision. Fixes #2765. #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪
|
azevaykin
approved these changes
Mar 15, 2024
|
⚪
|
snaury
added a commit
to snaury/ydb
that referenced
this pull request
Mar 15, 2024
This was referenced Mar 20, 2024
Merged
Merged
This was referenced Mar 29, 2024
Merged
This was referenced Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Fix missing locks on read iterator empty result elision.
Changelog category
Additional information
Jepsen showed incompatible-order failures when batching multiple operations into a single query. This was tracked to a read iterator improvement, where it tries to avoid repeating work on page faults by continuing in a new localdb transaction from the last observed key. Since it may produce internal continuations with empty intermediate results those are elided as "not useful". Unfortunately, in some cases, those results may contain information about acquired locks, which need to be passed to kqp. As a result of incorrect empty result elision transactions failed to detect serialization conflicts with other transactions, and successfully committed.