Improve build time for YT provider #3930
Conversation
|
⚪
|
|
⚪
|
|
⚪
|
|
⚪
|
| template<bool WithList> | ||
| TCoLambda MakeJobLambda(TCoLambda lambda, bool useFlow, TExprContext& ctx) const |
There was a problem hiding this comment.
Почему это не в helper?
И это вполне можно убрать в cpp, сделав две специализации
There was a problem hiding this comment.
Перенес в yql_yt_transformer_lambda.cpp две специализации.
| } | ||
|
|
||
|
|
||
| TMaybe<bool> CanFuseLambdas(const TCoLambda& innerLambda, const TCoLambda& outerLambda, TExprContext& ctx) const { |
| } | ||
|
|
||
| template <typename TLMapType> | ||
| TMaybeNode<TExprBase> LMap(TExprBase node, TExprContext& ctx) const { |
There was a problem hiding this comment.
реализацию стоит унести в yql_transform_map_reduce.cpp добавив две специализации шаблона
There was a problem hiding this comment.
Перенес в yql_yt_transformer.cpp
Оставил шаблонную функцию без специализаций, поскольку она вызывается только из того же .cpp файла
| } | ||
|
|
||
| template<bool IsTop> | ||
| TMaybeNode<TExprBase> Sort(TExprBase node, TExprContext& ctx) const { |
There was a problem hiding this comment.
Аналогично - реализацию унести в yql_transform_sort.cpp добавив две специализации шаблона
There was a problem hiding this comment.
Аналогично, перенес в yql_yt_transformer.cpp
alephonea
force-pushed
the
yt-speed-up-compilation
branch
from
cd3a021
to
b245f00
Compare
|
⚪ |
|
⚪ |
|
⚪
|
|
⚪
|
alephonea
force-pushed
the
yt-speed-up-compilation
branch
from
48f82f8
to
28775c0
Compare
|
⚪
|
|
⚪
|
alephonea
force-pushed
the
yt-speed-up-compilation
branch
from
28775c0
to
5fe31ea
Compare
|
⚪
|
|
⚪
|
Fix linking re templates move template to cpp file
alephonea
force-pushed
the
yt-speed-up-compilation
branch
from
5fe31ea
to
4a07866
Compare
|
⚪
|
|
⚪
|
yql_yt_physical_optimize.cpp took ~150s to compile, much longer than all other compilation units.
Break it down into multiple compile units to compile them in parallel.