Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add english version of CMS docs #4272

Merged
merged 10 commits into from
May 15, 2024

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented May 3, 2024

Changelog category

  • Documentation (changelog entry is not required)

Additional information

Russian version - #2097

@pixcc pixcc requested a review from a team as a code owner May 3, 2024 10:25
Copy link

github-actions bot commented May 3, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented May 3, 2024

❌ Documentation build

Revision build failed

Build logs

Errors (2)

❌ No such file or has no access to /en/manual/maintenance-without-downtime.md

❌ No such file or has no access to /ru/devops/..manual/maintenance-without-downtime.md

Copy link

github-actions bot commented May 3, 2024

❌ Documentation build

Revision build failed

Build logs

Errors (3)

❌ Link is unreachable: ../../administration/production-storage-config.md#reliability in /en/maintenance/manual/maintenance-without-downtime.md

❌ Link is unreachable: ../../administration/production-storage-config.md#reliability in /ru/maintenance/manual/maintenance-without-downtime.md

❌ Link is unreachable: ./concepts/cluster/common_scheme_ydb.md#tablets in /en/maintenance/manual/maintenance-without-downtime.md

@pixcc pixcc linked an issue May 3, 2024 that may be closed by this pull request
@pixcc pixcc requested a review from CyberROFL May 3, 2024 10:55
Copy link

github-actions bot commented May 3, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented May 3, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented May 3, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (159)

⚠️ /en/concepts/datamodel/_includes/table.md: 57: MD051/link-fragments Link fragments should be valid [Context: "AUTO_PARTITIONING_PARTITION_SIZE_MB"]

⚠️ /en/concepts/topic.md: 41: MD051/link-fragments Link fragments should be valid [Context: "partition"]

⚠️ /en/contributor/load-actors-storage.md: 12: MD051/link-fragments Link fragments should be valid [Context: "parameters of hard rate load"]

⚠️ /en/contributor/load-actors-storage.md: 23: MD051/link-fragments Link fragments should be valid [Context: "parameters of load with hard rate"]

⚠️ /en/contributor/load-actors-storage.md: 27: MD051/link-fragments Link fragments should be valid [Context: "parameters of load with hard rate"]

⚠️ /en/contributor/load-actors-storage.md: 31: MD051/link-fragments Link fragments should be valid [Context: "Class of data writes"]

⚠️ /en/contributor/load-actors-storage.md: 32: MD051/link-fragments Link fragments should be valid [Context: "Class of data reads"]

⚠️ /en/contributor/load-actors-storage.md: 33: MD051/link-fragments Link fragments should be valid [Context: "parameters for initial data allocation"]

⚠️ /en/contributor/load-actors-storage.md: 70: MD051/link-fragments Link fragments should be valid [Context: "Class of data writes"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/index.md: 15: MD051/link-fragments Link fragments should be valid [Context: "subcommands"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/stock.md: 11: MD051/link-fragments Link fragments should be valid [Context: "user-hist"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/stock.md: 12: MD051/link-fragments Link fragments should be valid [Context: "rand-user-hist"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/stock.md: 13: MD051/link-fragments Link fragments should be valid [Context: "add-rand-order"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/stock.md: 14: MD051/link-fragments Link fragments should be valid [Context: "put-rand-order"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/stock.md: 15: MD051/link-fragments Link fragments should be valid [Context: "put-same-order"]

Log was truncated. (144 records)

Copy link

github-actions bot commented May 6, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (159)

⚠️ /en/concepts/datamodel/_includes/table.md: 57: MD051/link-fragments Link fragments should be valid [Context: "AUTO_PARTITIONING_PARTITION_SIZE_MB"]

⚠️ /en/concepts/topic.md: 41: MD051/link-fragments Link fragments should be valid [Context: "partition"]

⚠️ /en/contributor/load-actors-storage.md: 12: MD051/link-fragments Link fragments should be valid [Context: "parameters of hard rate load"]

⚠️ /en/contributor/load-actors-storage.md: 23: MD051/link-fragments Link fragments should be valid [Context: "parameters of load with hard rate"]

⚠️ /en/contributor/load-actors-storage.md: 27: MD051/link-fragments Link fragments should be valid [Context: "parameters of load with hard rate"]

⚠️ /en/contributor/load-actors-storage.md: 31: MD051/link-fragments Link fragments should be valid [Context: "Class of data writes"]

⚠️ /en/contributor/load-actors-storage.md: 32: MD051/link-fragments Link fragments should be valid [Context: "Class of data reads"]

⚠️ /en/contributor/load-actors-storage.md: 33: MD051/link-fragments Link fragments should be valid [Context: "parameters for initial data allocation"]

⚠️ /en/contributor/load-actors-storage.md: 70: MD051/link-fragments Link fragments should be valid [Context: "Class of data writes"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/index.md: 15: MD051/link-fragments Link fragments should be valid [Context: "subcommands"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/stock.md: 11: MD051/link-fragments Link fragments should be valid [Context: "user-hist"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/stock.md: 12: MD051/link-fragments Link fragments should be valid [Context: "rand-user-hist"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/stock.md: 13: MD051/link-fragments Link fragments should be valid [Context: "add-rand-order"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/stock.md: 14: MD051/link-fragments Link fragments should be valid [Context: "put-rand-order"]

⚠️ /en/reference/ydb-cli/commands/workload/_includes/stock.md: 15: MD051/link-fragments Link fragments should be valid [Context: "put-same-order"]

Log was truncated. (144 records)

CyberROFL
CyberROFL previously approved these changes May 6, 2024
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

blinkov
blinkov previously requested changes May 6, 2024
ydb/docs/en/core/devops/manual/toc_p.yaml Outdated Show resolved Hide resolved
```
$ ydbops node maintenance --host <node_fqdn>
```
When executing this command, ydbops will acquire an exclusive lock on the node in CMS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph sounds weird: typically, multiple YDB nodes are on a single host, and such a command probably needs to acquire locks for all of them. Or maybe this implies only static/storage nodes, but this would need to be explicitly clarified, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed parameter to <node_id> to make it more clear. I just took this command from ydb-platform/ydbops#2
It is under active development. When the final variant of the command is chosen, the text in this article will be changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pixcc I don't think this change fixes the problem: in this article, we shouldn't use "node" and "host" interchangeably. This command sounds more like a maintenance of all (or some) nodes on a given host but not of a single node. Meanwhile, the surrounding text sounds like it is about a single node.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed command to eliminate ambiguity.

It's not 100% clear whether the final version of the command will take out a host for maintenance (with all nodes) or individual nodes, so I've settled on a simple node case for now.


To perform a rolling restart of the entire cluster you can use the command:
```
$ ydbops restart --endpoint grpc://<cluster-fqdn> --availability-mode strong
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this have some additional requirements? For instance, the last time I tried (a while ago), it couldn't restart a cluster deployed with Ansible because it relied on some different systemd unit naming.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things have changed a bit. By default the ydb-server-storage.service systemd name will be used, but it is possible to specify a different systemd unit name with --systemd-unit flag (here is a relevant --help output which contains this flag: https://pastebin.com/Jqcx31Jn).

Just for context: the fact that we have two different default unit names for deploying with Ansible and for everything else (cloud environments etc.) - is horrible and we just have to live with it for a while.

It is probably a good idea to include the mention of --system-unit flag into the docs, but not in too much detail, maybe one sentence only. E.g. "If your systemd unit name is different from the default one, you may need to override it with --systemd-unit flag"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added aditional requirements

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 6, 2024
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@pixcc pixcc requested a review from blinkov May 13, 2024 13:52
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov enabled auto-merge (squash) May 15, 2024 09:02
@blinkov blinkov merged commit ed038e2 into ydb-platform:main May 15, 2024
2 checks passed
naspirato pushed a commit to naspirato/ydb that referenced this pull request May 15, 2024
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
This was referenced Jun 7, 2024
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate CMS Docs
5 participants