Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send EndPartitionSession control message #4351

Merged
merged 23 commits into from
May 14, 2024

Conversation

nshestakov
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented May 7, 2024

2024-05-07 10:20:47 UTC Pre-commit check for 6cd364f has started.
2024-05-07 10:20:49 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-07 10:24:03 UTC Build successful.
2024-05-07 10:25:46 UTC Tests are running...
🔴 2024-05-07 11:37:00 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13143 11306 0 4 1823 10

Copy link

github-actions bot commented May 7, 2024

2024-05-07 10:20:49 UTC Pre-commit check for 6cd364f has started.
2024-05-07 10:20:52 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-07 10:24:10 UTC Build successful.

Copy link

github-actions bot commented May 7, 2024

2024-05-07 10:20:53 UTC Pre-commit check for 6cd364f has started.
2024-05-07 10:20:55 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-07 10:24:46 UTC Build successful.
2024-05-07 10:26:25 UTC Tests are running...
🔴 2024-05-07 12:07:36 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9053 8933 0 27 81 12

Copy link

github-actions bot commented May 8, 2024

2024-05-08 05:46:46 UTC Pre-commit check for 056fc4c has started.
2024-05-08 05:46:47 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-08 05:50:16 UTC Build successful.

Copy link

github-actions bot commented May 8, 2024

2024-05-08 05:49:42 UTC Pre-commit check for 056fc4c has started.
2024-05-08 05:49:44 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-08 05:52:57 UTC Build successful.

Copy link

github-actions bot commented May 8, 2024

2024-05-08 05:49:54 UTC Pre-commit check for 056fc4c has started.
2024-05-08 05:49:57 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-08 05:53:30 UTC Build successful.

Copy link

github-actions bot commented May 8, 2024

2024-05-08 06:00:11 UTC Pre-commit check for 2014e38 has started.
2024-05-08 06:00:14 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-08 06:03:35 UTC Build successful.

Copy link

github-actions bot commented May 8, 2024

2024-05-08 06:00:21 UTC Pre-commit check for 2014e38 has started.
2024-05-08 06:00:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-08 06:04:24 UTC Build successful.
2024-05-08 06:06:07 UTC Tests are running...
🔴 2024-05-08 07:50:02 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9058 8954 0 19 73 12

Copy link

github-actions bot commented May 8, 2024

2024-05-08 06:00:54 UTC Pre-commit check for 2014e38 has started.
2024-05-08 06:00:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-08 06:04:04 UTC Build successful.
2024-05-08 06:05:49 UTC Tests are running...
🔴 2024-05-08 07:17:37 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13153 11297 0 4 1843 9

@nshestakov nshestakov requested a review from a team as a code owner May 8, 2024 11:52
Copy link

github-actions bot commented May 8, 2024

2024-05-08 11:54:58 UTC Pre-commit check for f96d1b0 has started.
2024-05-08 11:55:00 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-08 12:08:26 UTC Build failed. see the build logs.

Copy link

github-actions bot commented May 8, 2024

2024-05-08 11:56:06 UTC Pre-commit check for f96d1b0 has started.
2024-05-08 11:56:09 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-08 12:11:27 UTC Build failed. see the build logs.
🔴 2024-05-08 12:13:00 UTC Tests run skipped.

Copy link

github-actions bot commented May 8, 2024

2024-05-08 11:56:19 UTC Pre-commit check for f96d1b0 has started.
2024-05-08 11:56:21 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-08 12:11:56 UTC Build failed. see the build logs.
🔴 2024-05-08 12:13:33 UTC Tests run skipped.

Copy link

github-actions bot commented May 8, 2024

2024-05-08 13:59:23 UTC Pre-commit check for 8b2b7c1 has started.
2024-05-08 13:59:26 UTC Build linux-x86_64-release-clang14 is running...
2024-05-08 14:23:24 UTC Check cancelled

Copy link

github-actions bot commented May 8, 2024

2024-05-08 13:59:38 UTC Pre-commit check for 8b2b7c1 has started.
2024-05-08 13:59:41 UTC Build linux-x86_64-release-asan is running...
2024-05-08 14:23:23 UTC Check cancelled

Copy link

github-actions bot commented May 14, 2024

2024-05-14 11:08:15 UTC Pre-commit check for cef9a2a has started.
2024-05-14 11:08:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-14 11:13:39 UTC Build successful.
2024-05-14 11:15:22 UTC Tests are running...
🔴 2024-05-14 13:00:03 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10829 10739 0 38 44 8

Copy link

github-actions bot commented May 14, 2024

2024-05-14 11:10:28 UTC Pre-commit check for cef9a2a has started.
2024-05-14 11:10:31 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-14 11:15:38 UTC Build successful.

Copy link

github-actions bot commented May 14, 2024

2024-05-14 11:10:32 UTC Pre-commit check for cef9a2a has started.
2024-05-14 11:10:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-14 11:15:26 UTC Build successful.
2024-05-14 11:17:09 UTC Tests are running...
🔴 2024-05-14 13:11:39 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69661 56463 0 1 13188 9

@nshestakov nshestakov enabled auto-merge (squash) May 14, 2024 14:16
@nshestakov nshestakov disabled auto-merge May 14, 2024 14:17
@kardymonds
Copy link
Collaborator

@nshestakov В каких случаях EndPartitionSession приходит и что означает?

@nshestakov
Copy link
Collaborator Author

nshestakov commented May 14, 2024

EndPartitionSession приходит когда известно, что с это все сообщения из партиции были вычитаны, и новых сообщений никогда не появится. Предполагается, что это подсказка клиенту закоммитить прочитанные offset-ы.

Это влияет на балансировку партиции. Пока оффсеты не закоммичены все дочерние партиции будут балансироваться в ту же сессию.

@nshestakov nshestakov merged commit 9539af5 into ydb-platform:main May 14, 2024
3 of 5 checks passed
@nshestakov nshestakov deleted the endPartitionSession branch May 14, 2024 15:04
naspirato pushed a commit to naspirato/ydb that referenced this pull request May 15, 2024
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
This was referenced Jun 7, 2024
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants