Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent "div by 0" during PickSessionToShutdown routine #4509

Merged
merged 2 commits into from
May 15, 2024
Merged

Prevent "div by 0" during PickSessionToShutdown routine #4509

merged 2 commits into from
May 15, 2024

Conversation

dcherednik
Copy link
Member

Changelog entry

...](#4507)

Changelog category

  • Bugfix

...

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

⚪ 2024-05-14 13:36:57 UTC Pre-commit check for 627e8e5 has started.
⚪ 2024-05-14 13:36:58 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-14 13:49:55 UTC Build successful.

@dcherednik dcherednik self-assigned this May 14, 2024
gridnevvvit
gridnevvvit previously approved these changes May 14, 2024
View reviewed changes
@va-kuznecov va-kuznecov added the bug Something isn't working label May 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

⚪ 2024-05-14 14:20:10 UTC Pre-commit check for 2d7ca58 has started.
⚪ 2024-05-14 14:20:11 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-14 14:21:10 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

⚪ 2024-05-14 14:23:53 UTC Pre-commit check for 2d7ca58 has started.
⚪ 2024-05-14 14:23:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-14 14:25:52 UTC Build successful.
⚪ 2024-05-14 14:27:27 UTC Tests are running...
🔴 2024-05-14 15:44:15 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12964 11124 0 2 1828 10

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

⚪ 2024-05-14 14:33:56 UTC Pre-commit check for 2d7ca58 has started.
⚪ 2024-05-14 14:33:58 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-14 14:35:47 UTC Build successful.
⚪ 2024-05-14 14:37:23 UTC Tests are running...
🔴 2024-05-14 16:15:17 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8998 8944 0 25 20 9

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

⚪ 2024-05-14 18:16:47 UTC Pre-commit check for 62bd2cb has started.
⚪ 2024-05-14 18:16:50 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-14 18:18:58 UTC Build successful.
⚪ 2024-05-14 18:20:55 UTC Tests are running...
🔴 2024-05-14 20:02:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9017 8969 0 21 20 7

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

⚪ 2024-05-14 18:16:54 UTC Pre-commit check for 62bd2cb has started.
⚪ 2024-05-14 18:16:56 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-14 18:19:05 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

⚪ 2024-05-14 18:16:56 UTC Pre-commit check for 62bd2cb has started.
⚪ 2024-05-14 18:16:59 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-14 18:19:05 UTC Build successful.
⚪ 2024-05-14 18:20:55 UTC Tests are running...
🔴 2024-05-14 19:31:16 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12974 11132 0 5 1828 9

@KirillKurdyukov KirillKurdyukov linked an issue May 14, 2024 that may be closed by this pull request
[bug]: parallel call http endpoint /actors/kqp_proxy?force_shutdown=all with the number of sessions > 1 will kill the database #4507
Closed
@dcherednik dcherednik enabled auto-merge (squash) May 15, 2024 09:17
@dcherednik dcherednik merged commit 73839e7 into ydb-platform:main May 15, 2024
3 of 5 checks passed
naspirato pushed a commit to naspirato/ydb that referenced this pull request May 15, 2024
@dcherednik @naspirato
Prevent "div by 0" during PickSessionToShutdown routine (ydb-platform…
e63d6fe 
…#4509)
@GrigoriyPA GrigoriyPA mentioned this pull request May 16, 2024
Closed
This was referenced May 16, 2024
Merged
Merged
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
This was referenced May 27, 2024
Closed
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@dcherednik @MrLolthe1st
Prevent "div by 0" during PickSessionToShutdown routine (ydb-platform…
e5f1a90 
…#4509)
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
This was referenced May 30, 2024
Merged
Closed
Closed
Merged
This was referenced Jun 7, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

@dcherednik dcherednik

Labels
bug Something isn't working bugfix
Projects
None yet
Milestone
No milestone
3 participants
@dcherednik @gridnevvvit @va-kuznecov