Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cms.proto] increase default DisabledNodesRatioLimit #4770

Merged
merged 3 commits into from
May 24, 2024

Conversation

blinkov
Copy link
Member

@blinkov blinkov commented May 23, 2024

With the current limit it is not possible to properly restart a minimal 8 or 9 nodes cluster as taking out even one node will lead to more than 10% of the cluster being down.

Example error:

May 23 08:46:16 static-node-3 ydbd[5559]: 2024-05-23T08:46:16.186419Z :CMS NOTICE: [AuditLog] [CMS tablet] Reply: request# NKikimr::NCms::TEvCms::TEvCheckRequest { User: "root" RequestId: "root-r-1" AvailabilityMode: MODE_MAX_AVAILABILITY }, response# NKikimr::NCms::TEvCms::TEvPermissionResponse { Status { Code: DISALLOW_TEMP Reason: "Cannot lock node \'5\' of tenant \'/Root\': too many unavailable nodes. Locked: 1, down: 0, total: 9, limit: 10%" } RequestId: "root-r-1" Deadline: 1716454276175013 }

Changelog category

  • Not for changelog (changelog entry is not required)

With the current limit it is not possible to properly restart a minimal 8 or 9 nodes cluster as taking out even one node will lead to more than 10% of the cluster being down.

Example error:
```
May 23 08:46:16 static-node-3 ydbd[5559]: 2024-05-23T08:46:16.186419Z :CMS NOTICE: [AuditLog] [CMS tablet] Reply: request# NKikimr::NCms::TEvCms::TEvCheckRequest { User: "root" RequestId: "root-r-1" AvailabilityMode: MODE_MAX_AVAILABILITY }, response# NKikimr::NCms::TEvCms::TEvPermissionResponse { Status { Code: DISALLOW_TEMP Reason: "Cannot lock node \'5\' of tenant \'/Root\': too many unavailable nodes. Locked: 1, down: 0, total: 9, limit: 10%" } RequestId: "root-r-1" Deadline: 1716454276175013 }
```
Copy link

github-actions bot commented May 23, 2024

2024-05-23 09:00:52 UTC Pre-commit check for fa1a5c6 has started.
2024-05-23 09:00:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 09:40:09 UTC Build successful.
2024-05-23 09:42:02 UTC Tests are running...
🔴 2024-05-23 11:37:50 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10681 10617 0 21 29 14

Copy link

github-actions bot commented May 23, 2024

2024-05-23 09:02:18 UTC Pre-commit check for fa1a5c6 has started.
2024-05-23 09:02:20 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 09:39:56 UTC Build successful.

Copy link

github-actions bot commented May 23, 2024

2024-05-23 09:02:47 UTC Pre-commit check for fa1a5c6 has started.
2024-05-23 09:02:48 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 09:40:25 UTC Build successful.
2024-05-23 09:42:02 UTC Tests are running...
🔴 2024-05-23 11:18:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38153 33357 0 2 4785 9

CyberROFL
CyberROFL previously approved these changes May 23, 2024
Copy link
Member

@pixcc pixcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blinkov blinkov enabled auto-merge (squash) May 24, 2024 02:35
@blinkov
Copy link
Member Author

blinkov commented May 24, 2024

@pixcc done

Copy link

github-actions bot commented May 24, 2024

2024-05-24 02:37:25 UTC Pre-commit check for 199dca0 has started.
2024-05-24 02:40:12 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 03:16:05 UTC Build successful.

Copy link

github-actions bot commented May 24, 2024

2024-05-24 02:38:13 UTC Pre-commit check for 199dca0 has started.
2024-05-24 02:41:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 03:20:27 UTC Build successful.
2024-05-24 03:20:44 UTC Tests are running...
🔴 2024-05-24 04:58:22 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38310 33510 0 5 4788 7

Copy link

github-actions bot commented May 24, 2024

2024-05-24 02:38:30 UTC Pre-commit check for 199dca0 has started.
2024-05-24 02:41:22 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 03:20:33 UTC Build successful.
2024-05-24 03:20:45 UTC Tests are running...
🔴 2024-05-24 05:24:06 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10842 10768 0 34 31 9

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants