Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make max commit size configurable with icb #4774

Merged
merged 1 commit into from
May 23, 2024
Merged

Make max commit size configurable with icb #4774

merged 1 commit into from
May 23, 2024

Conversation

snaury
Copy link
Member

@snaury snaury commented May 23, 2024

Changelog entry

Make max commit size configurable with ICB.

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Fixes #4766.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 10:01:30 UTC Pre-commit check for 3016e0d has started.
⚪ 2024-05-23 10:04:16 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 10:38:19 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 10:01:40 UTC Pre-commit check for 3016e0d has started.
⚪ 2024-05-23 10:04:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 10:45:03 UTC Build successful.
⚪ 2024-05-23 10:45:20 UTC Tests are running...
🔴 2024-05-23 12:44:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10830 10756 0 28 33 13

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 10:01:48 UTC Pre-commit check for 3016e0d has started.
⚪ 2024-05-23 10:04:48 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 10:46:00 UTC Build successful.
⚪ 2024-05-23 10:46:15 UTC Tests are running...
🔴 2024-05-23 12:25:33 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38305 33503 0 6 4788 8

@snaury snaury marked this pull request as ready for review May 23, 2024 13:30
@snaury snaury requested a review from the-ancient-1 May 23, 2024 13:30
the-ancient-1
the-ancient-1 approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@the-ancient-1 the-ancient-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snaury snaury merged commit 0342dc0 into ydb-platform:main May 23, 2024
4 of 6 checks passed
@snaury snaury deleted the tablet-max-commit-icb branch May 23, 2024 17:50
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
@snaury snaury self-assigned this May 24, 2024
This was referenced May 27, 2024
Closed
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@snaury @MrLolthe1st
Make max commit size configurable with icb (ydb-platform#4774)
2ce7784
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 19, 2024
Merged
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-ancient-1 the-ancient-1 the-ancient-1 approved these changes

Assignees

@snaury snaury

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ICB control for max commit size
2 participants
@snaury @the-ancient-1