You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signed char was used as the index value in the loop, collecting "to-be-removed" charset. As a result, processing all NonASCII bytes (i.e. greater than 127) leads to an invalid result. The patch changes the index value type to the unsigned one.
igormunkin
changed the title
YQLSUPPORT-5228: Fix String::RemoveAll for NonASCII input
YQLSUPPORT-5228: Fix Remove UDFs for NonASCII input
May 23, 2024
⚪ 2024-05-23 14:50:22 UTC Pre-commit check for de6b257 has started.
⚪ 2024-05-23 14:52:27 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-05-23 14:53:14 UTC Check cancelled
⚪ 2024-05-23 15:00:59 UTC Pre-commit check for eece0a9 has started.
⚪ 2024-05-23 15:03:16 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 15:05:38 UTC Build successful.
⚪ 2024-05-23 15:05:54 UTC Pre-commit check for eece0a9 has started.
⚪ 2024-05-23 15:08:49 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 15:11:01 UTC Build successful.
⚪ 2024-05-23 15:11:13 UTC Tests are running...
🔴 2024-05-23 15:56:27 UTC Test run completed, no test results found for commit 36d2225. Please check build logs.
⚫ 2024-05-23 15:56:33 UTC Check cancelled
⚪ 2024-05-23 15:07:24 UTC Pre-commit check for eece0a9 has started.
⚪ 2024-05-23 15:09:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 15:11:14 UTC Build successful.
⚪ 2024-05-23 15:11:23 UTC Tests are running...
🔴 2024-05-23 15:56:27 UTC Test run completed, no test results found for commit 36d2225. Please check build logs.
⚫ 2024-05-23 15:56:34 UTC Check cancelled
The signed char was used as the index value in the loop, collecting
"to-be-removed" charset. As a result, processing all NonASCII bytes
(i.e. greater than 127) leads to an invalid result. The patch changes
the index value type to the unsigned one.
Follows up ydb-platform#2836
The signed char was used as the index value in the loop, collecting
"to-be-removed" charset. As a result, processing all NonASCII bytes
(i.e. greater than 127) leads to an invalid result. The patch changes
the index value type to the unsigned one.
Follows up ydb-platform#2836
(cherry picked from ydb-platform#4789)
⚪ 2024-05-23 16:07:12 UTC Pre-commit check for b236f1d has started.
⚪ 2024-05-23 16:09:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 16:11:07 UTC Build successful.
⚪ 2024-05-23 16:11:16 UTC Tests are running...
🟢 2024-05-23 17:44:47 UTC Tests successful.
⚪ 2024-05-23 16:07:12 UTC Pre-commit check for b236f1d has started.
⚪ 2024-05-23 16:09:18 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 16:10:54 UTC Build successful.
⚪ 2024-05-23 16:09:36 UTC Pre-commit check for b236f1d has started.
⚪ 2024-05-23 16:11:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 16:13:28 UTC Build successful.
⚪ 2024-05-23 16:13:41 UTC Tests are running...
🔴 2024-05-23 17:32:21 UTC Some tests failed, follow the links below.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
igormunkin
changed the title
The signed char was used as the index value in the loop, collecting "to-be-removed" charset. As a result, processing all NonASCII bytes (i.e. greater than 127) leads to an invalid result. The patch changes the index value type to the unsigned one.
Follows up #2836
Changelog category