Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data() for getting pointer instead of begin() #4816

Merged
merged 1 commit into from
May 24, 2024

Conversation

4JustMe4
Copy link
Collaborator

Changelog entry

Avoid this type of errors on upcoming protobuf

$(SOURCE_ROOT)/contrib/ydb/core/driver_lib/run/kikimr_services_initializers.cpp:261:18: error: no matching constructor for initialization of 'TCpuMask'
        result = TCpuMask(cfg.GetX().begin(), cfg.GetX().size());
                 ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$(SOURCE_ROOT)/contrib/ydb/core/driver_lib/run/kikimr_services_initializers.cpp:314:26: note: in instantiation of function template specialization 'NKikimr::NKikimrServicesInitializers::ParseAffinity<NKikimrConfig::TAffinity>' requested here
        basic.Affinity = ParseAffinity(poolConfig.GetAffinity());
                         ^
$(SOURCE_ROOT)/contrib/ydb/library/actors/util/cpumask.h:26:5: note: candidate template ignored: could not match 'const T *' against 'const_iterator' (aka 'RepeatedIterator<const unsigned int>')
    TCpuMask(const T* cpus, TCpuId size) {
    ^
$(SOURCE_ROOT)/contrib/ydb/library/actors/util/cpumask.h:20:14: note: candidate constructor not viable: requires single argument 'cpuId', but 2 arguments were provided
    explicit TCpuMask(TCpuId cpuId) {
             ^
$(SOURCE_ROOT)/contrib/ydb/library/actors/util/cpumask.h:34:14: note: candidate constructor not viable: requires single argument 'cpuList', but 2 arguments were provided
    explicit TCpuMask(const TString& cpuList) {
             ^
$(SOURCE_ROOT)/contrib/ydb/library/actors/util/cpumask.h:13:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
struct TCpuMask {
       ^
$(SOURCE_ROOT)/contrib/ydb/library/actors/util/cpumask.h:13:8: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 2 were provided
$(SOURCE_ROOT)/contrib/ydb/library/actors/util/cpumask.h:17:5: note: candidate constructor not viable: requires 0 arguments, but 2 were provided
    TCpuMask() {}
    ^
1 error generated.

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented May 24, 2024

2024-05-24 09:26:56 UTC Pre-commit check for aefba74 has started.
2024-05-24 09:29:21 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 09:31:42 UTC Build successful.
2024-05-24 09:31:57 UTC Tests are running...
🔴 2024-05-24 10:48:28 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14791 13478 0 3 1301 9

Copy link

github-actions bot commented May 24, 2024

2024-05-24 09:27:45 UTC Pre-commit check for aefba74 has started.
2024-05-24 09:30:10 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 09:32:30 UTC Build successful.
2024-05-24 09:32:42 UTC Tests are running...
🔴 2024-05-24 11:22:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10665 10594 0 27 31 13

Copy link

github-actions bot commented May 24, 2024

2024-05-24 09:28:02 UTC Pre-commit check for aefba74 has started.
2024-05-24 09:30:32 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 09:34:41 UTC Build successful.

@maximyurchuk maximyurchuk merged commit 6f48846 into ydb-platform:main May 24, 2024
9 of 13 checks passed
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants