Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-3346 improve secrets fetching #5614

Merged
merged 1 commit into from
Jun 21, 2024
Merged

YQ-3346 improve secrets fetching #5614

merged 1 commit into from
Jun 21, 2024

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Jun 17, 2024 •
edited
Loading

Changelog entry

YQ-3346 improve secrets fetching

Changelog category

  • Improvement

Additional information

  • Send Ask after first subscribe reply (in case of secrets not found)
  • Removed MaximalSecretsSnapshotWaitTime

@GrigoriyPA GrigoriyPA requested a review from dorooleg June 17, 2024 08:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

⚪ 2024-06-17 08:48:00 UTC Pre-commit check for debea71 has started.
⚪ 2024-06-17 08:50:27 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-17 08:56:38 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

⚪ 2024-06-17 08:48:13 UTC Pre-commit check for debea71 has started.
⚪ 2024-06-17 08:50:47 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-17 08:54:42 UTC Build successful.
⚪ 2024-06-17 08:54:56 UTC Tests are running...
🔴 2024-06-17 10:16:20 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15088 13808 0 3 1266 11

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

⚪ 2024-06-17 08:48:17 UTC Pre-commit check for debea71 has started.
⚪ 2024-06-17 08:50:47 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-17 08:54:49 UTC Build successful.
⚪ 2024-06-17 08:55:00 UTC Tests are running...
🔴 2024-06-17 10:41:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10847 10808 0 9 20 10

@GrigoriyPA GrigoriyPA merged commit 2141961 into ydb-platform:main Jun 21, 2024
11 of 15 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3346-improve-secrets-fetching branch June 21, 2024 15:39
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Jun 21, 2024
@GrigoriyPA
YQ-3346 improve secrets fetching (ydb-platform#5614)
c13a63b
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Jun 22, 2024
@GrigoriyPA
YQ-3346 improve secrets fetching (ydb-platform#5614)
20c717b
This was referenced Jun 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorooleg dorooleg dorooleg approved these changes

Assignees
No one assigned
Labels
improvement new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrigoriyPA @dorooleg