Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normal stress coupling needs to be added to partial diffs #73

Open
martijnende opened this issue Sep 27, 2022 · 0 comments · May be fixed by #84
Open

Normal stress coupling needs to be added to partial diffs #73

martijnende opened this issue Sep 27, 2022 · 0 comments · May be fixed by #84
Assignees
@martijnende
Labels
bug
Milestone
3.0.0

Comments

@martijnende
Copy link
Collaborator

In derivs_all.f90:151 the time derivative of the normal stress needs to be added, i.e.:

    dmain_var = ( dtau_per + dtau_dt - sigma*dmu_dtheta*dth_dt - dtau_dP*dP_dt ) &
                     / ( sigma*dmu_dv + pb%zimpedance )

should become

    dmain_var = ( dtau_per + dtau_dt - sigma*dmu_dtheta*dth_dt - dtau_dP*(dP_dt - dsigma_dt) &
                     / ( sigma*dmu_dv + pb%zimpedance )

with dtau_dP = -mu (rename variable to make more sense...).

This only affects 3D simulations with FEAT_STRESS_COUPL = 1.
@martijnende martijnende added this to the 2.4.0 milestone Sep 27, 2022
@martijnende martijnende self-assigned this Sep 27, 2022
@martijnende martijnende mentioned this issue Sep 27, 2022
Closed
@martijnende martijnende linked a pull request Sep 27, 2022 that will close this issue
QDYN release 3.0.0 #70
Closed
martijnende added a commit that referenced this issue Sep 27, 2022
@martijnende
Fixed #73, removed redundant code
3f14bec
martijnende added a commit that referenced this issue Sep 28, 2022
@martijnende
Improved mesh builder (#71)
a1bab29 
* Added mesh builder
* Replaced print/exit statements in pyqdyn.py with proper exceptions
* Added dedicated logger to print messages to screen
* Fixed #73, removed redundant code
* Fixed bug in pyqdyn.py that caused the wrong dip/dw values to be read
@martijnende martijnende linked a pull request May 31, 2023 that will close this issue
Open
@martijnende martijnende linked a pull request May 31, 2023 that will close this issue
QDYN release 3.0.0 #84
Open
@martijnende martijnende removed a link to a pull request Mar 12, 2024
QDYN release 3.0.0 #70
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martijnende martijnende

Labels
bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

QDYN release 3.0.0 ydluo/qdyn
1 participant
@martijnende