Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency rubocop-rspec to v3 #712

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 11, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop-rspec (changelog) '2.31.0' -> '3.0.2' age adoption passing confidence

Release Notes

rubocop/rubocop-rspec (rubocop-rspec)

v3.0.2

Compare Source

  • Fix wrong autocorrect for RSpec/ScatteredSetup when hook contains heredoc. ([@​earlopain])
  • Fix false negative for RSpec/PredicateMatcher when expectation contains custom failure message. ([@​earlopain])
  • Facilitate the 3.0 upgrade flow with proper extracted cop messages. ([@​jeppester])

v3.0.1

Compare Source

  • Bump RuboCop requirement to +1.61. ([@​ydah])

v3.0.0

Compare Source

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. ([@​ydah])
  • Remove RuboCop::RSpec::Language::NodePattern. ([@​ydah])
  • Remove RSpec/FilePath cop. ([@​ydah])
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. ([@​ydah])
  • Add new RSpec/MissingExpectationTargetMethod cop. ([@​krororo])
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. ([@​earlopain])

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version\_3.html


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from d85e8e6 to 17982d8 Compare June 11, 2024 19:13
@yegor256
Copy link
Owner

@rultor please, try to merge, since 6 checks have passed

@rultor
Copy link
Collaborator

rultor commented Jun 19, 2024

@rultor please, try to merge, since 6 checks have passed

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jun 19, 2024

@rultor please, try to merge, since 6 checks have passed

@renovate[bot] @yegor256 Oops, I failed. You can see the full log here (spent 20min)

Saved 993 words to "/home/r/repo/_site/ru/2017/12/26/software-quality-formula.html" 
Saved 1224 words to "/home/r/repo/_site/en/2024/01/03/not-able-to-speak.html" 
Saved 839 words to "/home/r/repo/_site/zh/2024/01/03/not-able-to-speak.html" 
Saved 631 words to "/home/r/repo/_site/zh/2015/03/16/technical-glossaries.html" 
Saved 1254 words to "/home/r/repo/_site/ru/2015/03/16/technical-glossaries.html" 
Saved 732 words to "/home/r/repo/_site/zh/2020/03/03/prefixed-naming.html" 
Saved 1224 words to "/home/r/repo/_site/ru/2020/03/03/prefixed-naming.html" 
Saved 669 words to "/home/r/repo/_site/zh/2019/05/28/trust-or-not.html" 
Saved 1356 words to "/home/r/repo/_site/ru/2019/05/28/trust-or-not.html" 
Saved 623 words to "/home/r/repo/_site/zh/2022/02/16/ai-coding.html" 
Saved 1290 words to "/home/r/repo/_site/ru/2022/02/16/ai-coding.html" 
Saved 597 words to "/home/r/repo/_site/zh/2015/07/13/meetings-are-legalized-robbery.html" 
Saved 2392 words to "/home/r/repo/_site/ru/2015/07/13/meetings-are-legalized-robbery.html" 
Saved 1407 words to "/home/r/repo/_site/en/2017/03/02/history-of-separatism.html" 
Saved 830 words to "/home/r/repo/_site/zh/2017/03/02/history-of-separatism.html" 
Saved 609 words to "/home/r/repo/_site/zh/2014/04/17/how-xdsd-is-different.html" 
Saved 1480 words to "/home/r/repo/_site/ru/2014/04/17/how-xdsd-is-different.html" 
Saved 651 words to "/home/r/repo/_site/zh/2014/08/18/fluent-jdbc-decorator.html" 
Saved 865 words to "/home/r/repo/_site/ru/2014/08/18/fluent-jdbc-decorator.html" 
Saved 608 words to "/home/r/repo/_site/zh/2016/04/08/revenue-may-kill-startup.html" 
Saved 1233 words to "/home/r/repo/_site/ru/2016/04/08/revenue-may-kill-startup.html" 
Saved 651 words to "/home/r/repo/_site/zh/2019/03/19/logging-without-static-logger.html" 
Saved 1134 words to "/home/r/repo/_site/ru/2019/03/19/logging-without-static-logger.html" 
Saved 662 words to "/home/r/repo/_site/zh/2023/07/25/contribute-disabled-tests.html" 
Saved 972 words to "/home/r/repo/_site/ru/2023/07/25/contribute-disabled-tests.html" 
Saved 621 words to "/home/r/repo/_site/zh/2018/02/06/where-to-find-more-bugs.html" 
Saved 954 words to "/home/r/repo/_site/ru/2018/02/06/where-to-find-more-bugs.html" 
Saved 673 words to "/home/r/repo/_site/zh/2017/07/11/how-to-redesign-equals.html" 
Saved 981 words to "/home/r/repo/_site/ru/2017/07/11/how-to-redesign-equals.html" 
Saved 1217 words to "/home/r/repo/_site/en/2017/07/27/sabotage-failed.html" 
Saved 816 words to "/home/r/repo/_site/zh/2017/07/27/sabotage-failed.html" 
Saved 605 words to "/home/r/repo/_site/zh/2016/09/20/oop-without-classes.html" 
Saved 712 words to "/home/r/repo/_site/ru/2016/09/20/oop-without-classes.html" 
Saved 1184 words to "/home/r/repo/_site/en/2016/11/28/saakashvili-speaks-ukrainian.html" 
Saved 815 words to "/home/r/repo/_site/zh/2016/11/28/saakashvili-speaks-ukrainian.html" 
Saved 617 words to "/home/r/repo/_site/zh/2020/10/13/lack-of-problem.html" 
Saved 1052 words to "/home/r/repo/_site/ru/2020/10/13/lack-of-problem.html" 
                    done in 189.288 seconds.
 Auto-regeneration: disabled. Use --watch to enable.
Jekyll site generated without issues

All files are in place

There is no garbage

scss-lint found no lints
1 typos in _site/2016/03/08/pimp-up-your-resume.html: resumania
& resumania 11 14468: resuming, Tasmania, Romania, remain, presuming, resumes, resume, pressman, resume's, Rosanna, resumed
All typos:
  resumania
rake aborted!
8 typo(s) in 1 pages
/home/r/repo/Rakefile:231:in `block in <top (required)>'
/usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'
/usr/local/rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `eval'
/usr/local/rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `<main>'
Tasks: TOP => default => spell
(See full trace by running task with --trace)
container 0e5e9c74c01669353ac4da6742b8a5d84e6397ac0c5c5b61851a3627b66a7eba is dead
Wed Jun 19 19:11:59 UTC 2024

@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 17982d8 to eaae638 Compare July 4, 2024 23:33
@yegor256 yegor256 merged commit d908808 into master Jul 8, 2024
6 checks passed
@renovate renovate bot deleted the renovate/rubocop-rspec-3.x branch July 8, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants