Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtHead can be broken. #42

Closed
vssekorin opened this issue May 4, 2018 · 37 comments
Closed

HtHead can be broken. #42

vssekorin opened this issue May 4, 2018 · 37 comments
Labels
bug Something isn't working

Comments

@vssekorin
Copy link
Contributor

vssekorin commented May 4, 2018

Now HtHead reads block, then checks it. Therefore, the situation is possible:
... \r\n - block 1
\r\n ... - block 2
In this case, HtHead#stream does not find \r\n\r\n.

@0crat
Copy link
Collaborator

0crat commented May 4, 2018

@llorllale/z please, pay attention to this issue

@llorllale
Copy link
Collaborator

@0crat in

@0crat 0crat added the scope label May 15, 2018
@0crat
Copy link
Collaborator

0crat commented May 15, 2018

@0crat in (here)

@llorllale Job #42 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented May 15, 2018

Bug was reported, see §29: +15 point(s) just awarded to @vssekorin/z

@0crat
Copy link
Collaborator

0crat commented May 16, 2018

The job #42 assigned to @SharplEr/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

SharplEr added a commit to SharplEr/cactoos-http that referenced this issue May 22, 2018
@llorllale llorllale added the bug Something isn't working label May 22, 2018
@SharplEr
Copy link

@0crat waiting
Waiting for reviewer for #56

@0crat
Copy link
Collaborator

0crat commented May 26, 2018

@0crat waiting Waiting for reviewer for #56 (here)

@SharplEr The impediment for #42 was registered successfully by @SharplEr/z

SharplEr added a commit to SharplEr/cactoos-http that referenced this issue May 27, 2018
@SharplEr
Copy link

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Jul 18, 2018

@0crat refuse (here)

@SharplEr The user @SharplEr/z resigned from #42, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Jul 18, 2018

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @SharplEr/z

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

The job #42 assigned to @ammaratef45/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@ammaratef45
Copy link

@llorllale where is the design documentation for this? I can't figure it out without seeing the design

@llorllale
Copy link
Collaborator

@ammaratef45 do you have specific questions?

@ammaratef45
Copy link

ammaratef45 commented Jan 3, 2019

@llorllale The issue isn't clear for me,
What is the block and how can a block being terminated in the block after it

@llorllale
Copy link
Collaborator

@ammaratef45 the issue refers to the way HtHead reads the stream in "blocks" or chunks while parsing it, looking for the \r\n\r\n delimiter

@0crat
Copy link
Collaborator

0crat commented Jan 13, 2019

The job #42 assigned to @ilyakharlamov/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

ilyakharlamov added a commit to ilyakharlamov/cactoos-http that referenced this issue Jan 15, 2019
ilyakharlamov added a commit to ilyakharlamov/cactoos-http that referenced this issue Jan 17, 2019
ilyakharlamov added a commit to ilyakharlamov/cactoos-http that referenced this issue Jan 17, 2019
ilyakharlamov added a commit to ilyakharlamov/cactoos-http that referenced this issue Jan 17, 2019
ilyakharlamov added a commit to ilyakharlamov/cactoos-http that referenced this issue Jan 18, 2019
ilyakharlamov added a commit to ilyakharlamov/cactoos-http that referenced this issue Jan 20, 2019
ilyakharlamov added a commit to ilyakharlamov/cactoos-http that referenced this issue Jan 20, 2019
ilyakharlamov added a commit to ilyakharlamov/cactoos-http that referenced this issue Jan 21, 2019
ilyakharlamov added a commit to ilyakharlamov/cactoos-http that referenced this issue Jan 21, 2019
ilyakharlamov added a commit to ilyakharlamov/cactoos-http that referenced this issue Feb 21, 2019
@ilyakharlamov
Copy link
Contributor

@0crat status

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2019

@0crat status (here)

@ilyakharlamov This is what I know about this job in C63314D6Z, as in §32:

@ilyakharlamov
Copy link
Contributor

@llorllale ping, the PR was merged a while ago

@llorllale
Copy link
Collaborator

@ilyakharlamov ask the ticket's reporter if we can close this

@ilyakharlamov
Copy link
Contributor

@vssekorin ping

@ilyakharlamov
Copy link
Contributor

@vssekorin the PR was merged, I believe you can close this ticket.

@0crat
Copy link
Collaborator

0crat commented Jun 1, 2019

The job #42 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@victornoel
Copy link
Contributor

@vssekorin @llorllale someone can close this? the PR has been merged

@victornoel
Copy link
Contributor

@0crat waiting for issue to be closed

@0crat 0crat added the waiting label Jun 1, 2019
@0crat
Copy link
Collaborator

0crat commented Jun 1, 2019

@0crat waiting for issue to be closed (here)

@victornoel The impediment for #42 was registered successfully by @victornoel/z

@victornoel
Copy link
Contributor

@vssekorin @llorllale ping

@llorllale
Copy link
Collaborator

@vssekorin closed due to inactivity (PR #69 merged for this)

@0crat 0crat removed the waiting label Jun 7, 2019
@0crat
Copy link
Collaborator

0crat commented Jun 7, 2019

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jun 7, 2019
@0crat
Copy link
Collaborator

0crat commented Jun 7, 2019

The job #42 is now out of scope

@sereshqua
Copy link

sereshqua commented Jun 7, 2019

@victornoel should we wait until issue has been reviewed or already give quality bad here?

@victornoel
Copy link
Contributor

@sereshqua no, it's not needed, it is independent, thanks for checking :)

@sereshqua
Copy link

@0crat quality bad

@0crat
Copy link
Collaborator

0crat commented Jun 7, 2019

Quality is low, no payment, see §31

@0crat
Copy link
Collaborator

0crat commented Jun 7, 2019

Quality review completed: +4 point(s) just awarded to @sereshqua/z

@g4s8
Copy link

g4s8 commented Sep 16, 2019

@0crat status

@0crat
Copy link
Collaborator

0crat commented Sep 16, 2019

@0crat status (here)

@g4s8 This is what I know about this job in C63314D6Z, as in §32:

  • The job #42 is not in scope
  • Job footprint (restricted area)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants