Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringsInCamelCase #1678

Closed
wants to merge 3 commits into from
Closed

StringsInCamelCase #1678

wants to merge 3 commits into from

Conversation

h1alexbel
Copy link
Contributor

@h1alexbel h1alexbel commented Mar 21, 2023

Hi @victornoel and @yegor256!
While developing eo-kafka we realized that we need an object that will take a collection of strings and camel-cased them.
We have an actual implementation, but to make it more reusable we can try to push it into the cactoos.org library to have a nice ability to use this object in other our projects.

So, take a look, please.

@victornoel
Copy link
Collaborator

@h1alexbel thank you, let's see if 0crat assign a reviewer :)

@victornoel
Copy link
Collaborator

@0crat in

@victornoel
Copy link
Collaborator

@h1alexbel I'm wondering if instead, won't we want a new class that allows to upper case one string? and then anybody can use iterable.Mapped to apply it to an iterable of string? This class would implement Text

@victornoel
Copy link
Collaborator

@h1alexbel hehe, actually this already exists: https://github.com/yegor256/cactoos/blob/master/src/main/java/org/cactoos/text/Capitalized.java

So either we don't need the proposed change, or maybe rewrite it with Capitalized to see how it goes?

@h1alexbel
Copy link
Contributor Author

@victornoel yeah, Capitalized will be our choice. Thanks for the advice!

@0crat
Copy link
Collaborator

0crat commented Mar 27, 2023

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Mar 27, 2023

Pull request #1678 was not merged, no payment for ARC, see §28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants