Code in ctors

[akryvtsun]

In some ctors we have method calls for JDK's standard static methods. E.g.
https://github.com/yegor256/cactoos/pull/22/files#diff-537f42dacf5c41ee51d8dc12c8560ce5R51
or
https://github.com/yegor256/cactoos/pull/22/files#diff-537f42dacf5c41ee51d8dc12c8560ce5R73
Also look on ctors in
https://github.com/yegor256/cactoos/blob/master/src/main/java/org/cactoos/text/FormattedText.java
in master branch.

Sometimes we even have some non static JDK calls. E.g.
#20 (diff)

Question: have we avoid all of such method calls at all? So, literally,

Only new calls are available in ctors

rule everywhere?

It yes, have we avoid usage standard Arrays.asList and Collections.unmodifiableSet and create substitute for them?

[0crat]

@Englishman I'm not managing this repo, remove the webhook or contact me in Slack //cc @yegor256

[g4s8]

@Englishman I've never tried before this approach (only new in constructors) but it looks interesting. As for Collections.unmodifiableSet and Arrays.asList I think we should avoid jdk static methods like any other static methods in constructor because they are procedures, so if we use procedures in constructors we put a code in constructors.

[akryvtsun]

@g4s8 basically the idea is from here
http://www.yegor256.com/2015/05/07/ctors-must-be-code-free.html

[g4s8]

@Englishman yes, I've read it, but I thought this rule is less strict. Like do not put a lot of code in contructor but one or two method calls is ok.

[akryvtsun]

@g4s8 yes, I guessed so. But look on this part of discussion
#20 (comment)

[yegor256]

@Englishman yes, we must avoid any code in constructors. So, these static method calls are evil, but if you look at what's inside them, you will see that they are actually just making new objects. But I agree that we should create substitutes for them. Feel free to submit PRs.

[yegor256]

@Englishman is this ticket still actual? I believe we can close it

[ghost]

@yegor256 @Englishman please close this issue as it's actually a number of issues:

1. introduce class for Locale.getDefault issue
2. update 20 usages of Arrays.asList issue
3. update 61 usages of Collections... issue

[yegor256]

@ashtonhogan why me?

[llorllale]

@Englishman please close this issue

[llorllale]

@Englishman can we close this?

[llorllale]

@Englishman closing

[0crat]

The job is not in WBS, won't close the order