Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckedScalar #735

Closed
Vatavuk opened this issue Mar 12, 2018 · 29 comments
Closed

CheckedScalar #735

Vatavuk opened this issue Mar 12, 2018 · 29 comments

Comments

@Vatavuk
Copy link
Contributor

Vatavuk commented Mar 12, 2018

Let's create CheckedScalar which will throw exception specified by user.

class CheckedScalar<T, E extends Exception> implements Scalar<T> {
     //...fields and ctors
    @Override
    public T value() throws E {
        //...
    }
}

For more details see discussion in issue #656
I can submit PR if you agree.

@0crat
Copy link
Collaborator

0crat commented Mar 12, 2018

@yegor256/z please, pay attention to this issue

@yegor256
Copy link
Owner

@0crat assign @Vatavuk

@0crat 0crat added the scope label Mar 13, 2018
@0crat
Copy link
Collaborator

0crat commented Mar 13, 2018

@0crat assign @Vatavuk (here)

@yegor256 Thanks for your contribution, @Vatavuk/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

@0crat
Copy link
Collaborator

0crat commented Mar 13, 2018

@0crat assign @Vatavuk (here)

@yegor256 The job #735 assigned to @Vatavuk/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this. @Vatavuk/z is not a member of this project yet, but they can request to join, as §1 explains

@0crat
Copy link
Collaborator

0crat commented Mar 13, 2018

Manual assignment of issues is discouraged, see §19: -5 points just awarded to @yegor256/z

@0crat
Copy link
Collaborator

0crat commented Mar 13, 2018

It is strongly discouraged to assign jobs to their creators, see §19: -15 points just awarded to @yegor256/z

Vatavuk pushed a commit to Vatavuk/cactoos that referenced this issue Mar 13, 2018
@0crat
Copy link
Collaborator

0crat commented Mar 18, 2018

@Vatavuk/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@Vatavuk
Copy link
Contributor Author

Vatavuk commented Mar 20, 2018

@yegor256 I would like to raise an impediment because the reviewer is not responding to my PR #738 .
I can't command 0crat since I'm not a member of the project. Could you help?

@0crat
Copy link
Collaborator

0crat commented Mar 21, 2018

@Vatavuk/z this job was assigned to you 8 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@yegor256
Copy link
Owner

@Vatavuk try to talk to Zerocrat, he should listen to you

@Vatavuk
Copy link
Contributor Author

Vatavuk commented Mar 21, 2018

@0crat waiting
Waiting for reviewer reaction.

@0crat
Copy link
Collaborator

0crat commented Mar 21, 2018

You need to ask somebody to invite you: https://github.com/zerocracy/datum#invite-only

@Vatavuk
Copy link
Contributor Author

Vatavuk commented Mar 21, 2018

@yegor256 I would like to join the "Gang" to more actively contribute to this project. Could you invite me?

@yegor256
Copy link
Owner

@Vatavuk fill this form, someone will help: https://www.0crat.com/join

@Vatavuk
Copy link
Contributor Author

Vatavuk commented Mar 22, 2018

@0crat waiting
Compensating time for absence of reviewer response.

@0crat
Copy link
Collaborator

0crat commented Mar 22, 2018

@0crat waiting Compensating time for absence of reviewer response. (here)

@Vatavuk The impediment for #735 was registered successfully by @Vatavuk/z

@Vatavuk
Copy link
Contributor Author

Vatavuk commented Apr 2, 2018

This issue is resolved in PR #738

@Vatavuk Vatavuk closed this as completed Apr 2, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 2, 2018

@Vatavuk/z the issue is closed not by @Vatavuk (its creator); I won't close the order; please, re-open it and ask @Vatavuk to close it

@Vatavuk Vatavuk reopened this Apr 2, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 2, 2018

@yegor256/z please, pay attention to this issue

@Vatavuk
Copy link
Contributor Author

Vatavuk commented Apr 2, 2018

@yegor256 0crat won't close the order. How to deal with this?

@yegor256
Copy link
Owner

yegor256 commented Apr 2, 2018

@Vatavuk it was a bug; try to close again, please.

@Vatavuk Vatavuk closed this as completed Apr 2, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 2, 2018

@elenavolokhova/z please review this job completed by @Vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Apr 2, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 2, 2018

The job #735 is now out of scope

@elenavolokhova
Copy link

@Vatavuk According to our Policy

Problem reporter and problem solver are two different persons;

Please, confirm, that you will try to avoid fixing your own issues in future.

@Vatavuk
Copy link
Contributor Author

Vatavuk commented Apr 2, 2018

@elenavolokhova I confirm.

@elenavolokhova
Copy link

@Vatavuk Thanks!

@elenavolokhova
Copy link

@0crat quality acceptable

@0crat
Copy link
Collaborator

0crat commented Apr 2, 2018

Order was finished, quality is "acceptable": +30 point(s) just awarded to @Vatavuk/z

@0crat
Copy link
Collaborator

0crat commented Apr 2, 2018

Quality review completed: +8 point(s) just awarded to @elenavolokhova/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants