Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few configuration issues #815

Closed
krzyk opened this issue May 4, 2018 · 15 comments
Closed

Few configuration issues #815

krzyk opened this issue May 4, 2018 · 15 comments
Assignees
Labels

Comments

@krzyk
Copy link
Contributor

krzyk commented May 4, 2018

  1. .travis.yml:
  • we don't need gem install est (and do we need xcop?, I don't see it used anywhere)
  • script should have pdd --source=$(pwd) --verbose --file=/dev/null (just like in .rultor.yml) to catch PDD errors early
  • mvn clean site -Psite --errors --batch-mode should be after mvn clean install ...
  1. .rultor.yml:
  • -XX:MaxPermSize=256m should be removed (it is not used by java 8)
  • architects section should have llorllale first (so he will asked by rultor after reviewer does @rultor merge)
  • pdd --source=$(pwd) --verbose --file=/dev/null should be first in the merge part (to catch PDD errors early without doing long maven build)
  • do we need sudo gem install --no-rdoc --no-ri xcop?

And general question, do we deploy the result of mvn site anywhere? It is build in both rultor and travis, but I don't know if there is a point in doing two almost full maven builds if we don't put the site anywhere.

@0crat
Copy link
Collaborator

0crat commented May 4, 2018

@llorllale/z please, pay attention to this issue

@llorllale
Copy link
Contributor

@0crat in

@llorllale llorllale self-assigned this May 6, 2018
@0crat 0crat added the scope label May 6, 2018
@0crat
Copy link
Collaborator

0crat commented May 6, 2018

@0crat in (here)

@llorllale Job #815 is now in scope, role is DEV

@llorllale
Copy link
Contributor

@0crat assign @llorllale

@0crat
Copy link
Collaborator

0crat commented May 6, 2018

The job #815 assigned to @llorllale/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@0crat
Copy link
Collaborator

0crat commented May 6, 2018

@0crat in (here)

@llorllale Job gh:yegor256/cactoos#815 already assigned to @llorllale, can't assign to @llorllale

@llorllale llorllale added the bug label May 6, 2018
@0crat
Copy link
Collaborator

0crat commented May 6, 2018

Bug was reported, see §29: +15 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented May 6, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @llorllale/z

@0crat
Copy link
Collaborator

0crat commented May 6, 2018

@0crat assign @llorllale (here)

@llorllale Job #815 is already assigned to @llorllale/z

@llorllale
Copy link
Contributor

llorllale commented May 6, 2018

@krzyk
.travis.yml:

  1. xcop is being invoked via jcabi-parent. It's not obvious, but look for example in this rultor or this travis build log for the string "looks good"
  2. est: I agree, we aren't using it. pdd does not list it as a runtime dependency.
  3. Why should mvn clean site be after mvn clea install?
  4. I will add pdd to the travis build

.rultor.yml

  1. Will remove -XX:MaxPermSize=256m
  2. Will rearrange list of architects
  3. Will make pdd run first
  4. xcop is required for the same reasons as in the travis build

@krzyk
Copy link
Contributor Author

krzyk commented May 6, 2018

@llorllale just ignore the clean site comment

llorllale added a commit that referenced this issue May 8, 2018
@llorllale
Copy link
Contributor

@krzyk fixed in f9315fe

I think we can close this?

@krzyk
Copy link
Contributor Author

krzyk commented May 8, 2018

@llorllale thanks

@krzyk krzyk closed this as completed May 8, 2018
@0crat 0crat removed the scope label May 8, 2018
@0crat
Copy link
Collaborator

0crat commented May 8, 2018

Order was finished: +30 point(s) just awarded to @llorllale/z

@0crat
Copy link
Collaborator

0crat commented May 8, 2018

The job #815 is now out of scope

paulodamaso pushed a commit to paulodamaso/cactoos that referenced this issue May 9, 2018
Vatavuk pushed a commit to Vatavuk/cactoos that referenced this issue May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants