-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCM calculation is wrong #447
Comments
@paulodamaso/z please, pay attention to this issue |
@0crat in |
@vzurauskas why does NCC equals 1 ? It is the number of connected components, there are 4 methods and they are all connected to another method, so it should be 4, no? And thus, CCM should be 6/(6x4) = 0.25 |
@vzurauskas my bad, I better understand now, the number of connected component is the set of 4 methods that are connected together, so it is 1. |
Found with sort metricstest-params.csv | uniq -d
@vzurauskas the problem is that the constructor is counted as one of the methods. Furthermore I realised that the computation for NCC is incorrect (even though in this particular case it computes the correct result of 1). I opened #449 for that since it wasn't related to the bug you uncovered. |
@vzurauskas the puzzle #453 is still not solved. |
@vzurauskas the PR has been merged and the work will continue in #453. Can you close this issue? |
@victornoel Closing, thanks. |
@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@0crat quality good |
@vzurauskas the only puzzle #453 is solved here. |
In
metricstest-params
there is a lineOverloadMethods,CCM,0.6d
. This meansOverloadMethods
class from the test samples has CCM of 0.6.CCM = NC/(NMP x NCC)
In
OverloadMethods
there are 4 methods, each accessing the same attribute. So:NC = 6
NMP = 6
NCC = 1
Therefore CCM should be 1.0, not 0.6.
The text was updated successfully, but these errors were encountered: