Fix for #46. #134
Fix for #46. #134
Conversation
|
Let me find a reviewer for this pull request, thanks for submitting it |
|
@longtimeago this pull request is for you, please review |
|
@popprem please, fix checkstyle issues. |
|
@longtimeago Tried mvn clean install -Pqulice in local, build is successful. Do i need to do any configurations for checkstyle? unable to reproduce it locally. Please advice. |
|
@popprem what OS, maven, java do you use? |
|
@longtimeago Im using Windows 7, maven 3.2.5, java 1.7. |
|
@popprem maybe you have some not pushed commits? |
|
@longtimeago Just cloned the branch for #46 to a new location and built it. Again the build is successful. May be -Pqulice not working in my environment. |
|
@popprem do you see following line in your traces? ? |
|
@longtimeago No, i don't see that trace, that's the reason i doubted that -Pqulice is not working in my enviornment. I'm trying to figure out why it is not working. |
|
@popprem well ... from which folder did you run maven build? |
|
@longtimeago Inside takes folder (cloned directory) - where the first level pom.xml is.. same level of src folder. |
|
@popprem please, post your build traces somehow |
|
@longtimeago Just cleared my workspace again, installed the softwares and tried, it is working now. :) Not sure what happened earlier. But, currently i'm getting many checkstyle issues in different files: ......... Seems like this issue was fixed here jcabi/jcabi-aether#59. Is this only for linux environment? |
|
I've created an issue for current repository #148 |
|
@popprem please, try again. Maybe, you would need to do a fresh clone of repo. |
|
@popprem it's up to you, you won't be paid for it anyway |
|
Just to finish up what i did. Please review pull request #169. |
|
@elenavolokhova please, let us know what do you think about this ticket, according to our QA rules |
|
According to our quality rules:
Some comments are not addressed to anybody:
According to our quality rules:
There is a not meaningful title. According to our quality rules:
There is no link to original ticket. According to our quality rules:
I think such logs should use some styling:
Please make sure that everyone follows this rule in your tickets in the future. Please confirm that everything is clear and you have no questions regarding this approach. |
|
@elenavolokhova everything is clear |
|
@elenavolokhova PR was closed by reporter. No need to review it's quality |
|
@davvd Quality is bad here. |
@elenavolokhova thanks a lot, noticing bad quality is what makes us better |
|
@longtimeago I added 10 mins to @elenavolokhova (for QA review) in transaction 55976080 25 mins was added to your account, many thanks for your contribution! The task took 55976118. you're getting extra minutes here (c=10) added +25 to your rating, now it is equal to +4649 |
Validation introduced for non printable characters in cookie name/value attributes. Tests added.