Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #46. #134

Closed
wants to merge 2 commits into from
Closed

Fix for #46. #134

wants to merge 2 commits into from

Conversation

popprem
Copy link
Contributor

@popprem popprem commented Apr 5, 2015

Validation introduced for non printable characters in cookie name/value attributes. Tests added.

@davvd
Copy link

davvd commented Apr 5, 2015

Let me find a reviewer for this pull request, thanks for submitting it

@davvd
Copy link

davvd commented Apr 5, 2015

@longtimeago this pull request is for you, please review

@longtimeago
Copy link

@popprem please, fix checkstyle issues.
Run mvn clean install -Pqulice to see what's wrong

@popprem
Copy link
Contributor Author

popprem commented Apr 6, 2015

@longtimeago Tried mvn clean install -Pqulice in local, build is successful. Do i need to do any configurations for checkstyle? unable to reproduce it locally. Please advice.

@longtimeago
Copy link

@popprem what OS, maven, java do you use?

@popprem
Copy link
Contributor Author

popprem commented Apr 6, 2015

@longtimeago Im using Windows 7, maven 3.2.5, java 1.7.

@longtimeago
Copy link

@popprem maybe you have some not pushed commits?

@popprem
Copy link
Contributor Author

popprem commented Apr 6, 2015

@longtimeago Just cloned the branch for #46 to a new location and built it. Again the build is successful. May be -Pqulice not working in my environment.

@longtimeago
Copy link

@popprem do you see following line in your traces?

qulice-maven-plugin:0.12:check (jcabi-check) @ takes

?
What is next?

@popprem
Copy link
Contributor Author

popprem commented Apr 6, 2015

@longtimeago No, i don't see that trace, that's the reason i doubted that -Pqulice is not working in my enviornment. I'm trying to figure out why it is not working.

@longtimeago
Copy link

@popprem well ... from which folder did you run maven build?

@popprem
Copy link
Contributor Author

popprem commented Apr 6, 2015

@longtimeago Inside takes folder (cloned directory) - where the first level pom.xml is.. same level of src folder.

@longtimeago
Copy link

@popprem please, post your build traces somehow

@popprem
Copy link
Contributor Author

popprem commented Apr 7, 2015

@longtimeago Just cleared my workspace again, installed the softwares and tried, it is working now. :) Not sure what happened earlier. But, currently i'm getting many checkstyle issues in different files:

.........
[ERROR] \src\test\java\org\takes\http\FtBasicTest.java[92]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\FtBasicTest.java[123]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\FtBasicTest.java[158]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\FtBasicTest.java[160]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\FtCLITest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\http\FtCLITest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\FtCLITest.java[35]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\FtCLITest.java[44]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\FtCLITest.java[90]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\FtCLITest.java[105]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\FtCLITest.java[107]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\OptionsTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\http\OptionsTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\OptionsTest.java[28]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\OptionsTest.java[36]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\OptionsTest.java[55]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\OptionsTest.java[57]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\package-info.java[1]: Missing a header - not enough lines in file. (HeaderCheck)
[ERROR] \src\test\java\org\takes\http\package-info.java[23]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\package-info.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\misc\HrefTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\misc\HrefTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\misc\HrefTest.java[29]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\misc\HrefTest.java[37]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\misc\HrefTest.java[54]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\misc\HrefTest.java[67]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\misc\HrefTest.java[84]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\misc\package-info.java[1]: Missing a header - not enough lines in file. (HeaderCheck)
[ERROR] \src\test\java\org\takes\misc\package-info.java[23]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\misc\package-info.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\package-info.java[1]: Missing a header - not enough lines in file. (HeaderCheck)
[ERROR] \src\test\java\org\takes\package-info.java[23]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\package-info.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\package-info.java[1]: Missing a header - not enough lines in file. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\package-info.java[23]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\package-info.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqCookiesTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\RqCookiesTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqCookiesTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqCookiesTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqCookiesTest.java[59]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqCookiesTest.java[80]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqCookiesTest.java[103]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqCookiesTest.java[105]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqFormTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\RqFormTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqFormTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqFormTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqFormTest.java[63]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqFormTest.java[65]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHeadersTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\RqHeadersTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHeadersTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHeadersTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHeadersTest.java[59]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHeadersTest.java[81]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHeadersTest.java[83]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHrefTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\RqHrefTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHrefTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHrefTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHrefTest.java[59]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHrefTest.java[80]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHrefTest.java[100]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqHrefTest.java[102]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqLiveTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\RqLiveTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqLiveTest.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqLiveTest.java[40]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqLiveTest.java[67]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqLiveTest.java[69]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqMethodTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\RqMethodTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqMethodTest.java[29]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqMethodTest.java[37]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqMethodTest.java[50]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqMultipartTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\RqMultipartTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqMultipartTest.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqMultipartTest.java[42]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqMultipartTest.java[86]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqMultipartTest.java[88]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqPrintTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\RqPrintTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqPrintTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqPrintTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqPrintTest.java[60]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqPrintTest.java[62]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithHeaderTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithHeaderTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithHeaderTest.java[29]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithHeaderTest.java[37]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithHeaderTest.java[54]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithHeaderTest.java[56]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithoutHeaderTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithoutHeaderTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithoutHeaderTest.java[29]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithoutHeaderTest.java[37]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithoutHeaderTest.java[54]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rq\RqWithoutHeaderTest.java[56]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\package-info.java[1]: Missing a header - not enough lines in file. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\package-info.java[23]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\package-info.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsGzipTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\RsGzipTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsGzipTest.java[37]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsGzipTest.java[46]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsGzipTest.java[64]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsGzipTest.java[87]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsGzipTest.java[89]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsJSONTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\RsJSONTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsJSONTest.java[31]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsJSONTest.java[39]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsJSONTest.java[57]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsJSONTest.java[59]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsPrintTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\RsPrintTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsPrintTest.java[27]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsPrintTest.java[35]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsPrintTest.java[44]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsPrintTest.java[46]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsTextTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\RsTextTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsTextTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsTextTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsTextTest.java[58]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsTextTest.java[60]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsVelocityTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\RsVelocityTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsVelocityTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsVelocityTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsVelocityTest.java[55]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsVelocityTest.java[57]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithCookieTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithCookieTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithCookieTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithCookieTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithCookieTest.java[62]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithCookieTest.java[64]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeadersTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeadersTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeadersTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeadersTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeadersTest.java[64]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeadersTest.java[66]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeaderTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeaderTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeaderTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeaderTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeaderTest.java[63]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithHeaderTest.java[65]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithoutHeaderTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithoutHeaderTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithoutHeaderTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithoutHeaderTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithoutHeaderTest.java[61]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsWithoutHeaderTest.java[63]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsXSLTTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\RsXSLTTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsXSLTTest.java[27]: Unused import - com.jcabi.matchers.XhtmlMatchers. (UnusedImportsCheck)
[ERROR] \src\test\java\org\takes\rs\RsXSLTTest.java[30]: Unused import - java.nio.charset.Charset. (UnusedImportsCheck)
[ERROR] \src\test\java\org\takes\rs\RsXSLTTest.java[34]: Unused import - org.apache.commons.io.IOUtils. (UnusedImportsCheck)
[ERROR] \src\test\java\org\takes\rs\RsXSLTTest.java[37]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsXSLTTest.java[45]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsXSLTTest.java[84]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsXSLTTest.java[117]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\RsXSLTTest.java[119]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\package-info.java[1]: Missing a header - not enough lines in file. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\xe\package-info.java[23]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\package-info.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\RsXemblyTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\xe\RsXemblyTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\RsXemblyTest.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\RsXemblyTest.java[40]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\RsXemblyTest.java[71]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\RsXemblyTest.java[73]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeDateTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeDateTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeDateTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeDateTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeDateTest.java[59]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeDateTest.java[61]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkHomeTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkHomeTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkHomeTest.java[31]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkHomeTest.java[39]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkHomeTest.java[60]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkHomeTest.java[62]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkSelfTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkSelfTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkSelfTest.java[31]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkSelfTest.java[39]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkSelfTest.java[60]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkSelfTest.java[62]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkTest.java[59]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLinkTest.java[61]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLocalhostTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLocalhostTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLocalhostTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLocalhostTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLocalhostTest.java[59]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeLocalhostTest.java[61]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeSLATest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeSLATest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeSLATest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeSLATest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeSLATest.java[59]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\rs\xe\XeSLATest.java[61]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\package-info.java[1]: Missing a header - not enough lines in file. (HeaderCheck)
[ERROR] \src\test\java\org\takes\tk\package-info.java[23]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\package-info.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkHTMLTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\tk\TkHTMLTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkHTMLTest.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkHTMLTest.java[40]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkHTMLTest.java[60]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkHTMLTest.java[78]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkHTMLTest.java[80]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkMeasuredTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\tk\TkMeasuredTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkMeasuredTest.java[30]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkMeasuredTest.java[38]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkMeasuredTest.java[53]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkMeasuredTest.java[72]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkRedirectTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\tk\TkRedirectTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkRedirectTest.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkRedirectTest.java[48]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkRedirectTest.java[70]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkRedirectTest.java[92]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkRedirectTest.java[94]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkTextTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\tk\TkTextTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkTextTest.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkTextTest.java[40]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkTextTest.java[60]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkTextTest.java[78]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkTextTest.java[80]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkWithHeadersTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\tk\TkWithHeadersTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkWithHeadersTest.java[31]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkWithHeadersTest.java[39]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\tk\TkWithHeadersTest.java[68]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\package-info.java[1]: Missing a header - not enough lines in file. (HeaderCheck)
[ERROR] \src\test\java\org\takes\ts\package-info.java[23]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\package-info.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsClasspathTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\ts\TsClasspathTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsClasspathTest.java[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsClasspathTest.java[40]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsClasspathTest.java[58]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsClasspathTest.java[69]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsClasspathTest.java[71]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsFilesTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\ts\TsFilesTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsFilesTest.java[35]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsFilesTest.java[43]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsFilesTest.java[63]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsFilesTest.java[74]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsFilesTest.java[76]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsVerboseTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\ts\TsVerboseTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsVerboseTest.java[34]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsVerboseTest.java[42]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsVerboseTest.java[64]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsVerboseTest.java[66]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsVersionedTest.java[4]: Line does not match expected header line of ' *'. (HeaderCheck)
[ERROR] \src\test\java\org\takes\ts\TsVersionedTest.java[24]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsVersionedTest.java[31]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsVersionedTest.java[39]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsVersionedTest.java[55]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\ts\TsVersionedTest.java[57]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\resources\log4j.properties[23]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\resources\log4j.properties[25]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\resources\log4j.properties[29]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\resources\log4j.properties[32]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\www.takes.org\index.html[41]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\www.takes.org\index.html[42]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[INFO] Read our quality policy: http://www.qulice.com/quality.html
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38.109 s
[INFO] Finished at: 2015-04-07T08:40:49+05:30
[INFO] Final Memory: 37M/509M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.qulice:qulice-maven-plugin:0.12:check (jcabi-check) on project takes: Failure: 1983 Checkstyle violations (see log
above) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Seems like this issue was fixed here jcabi/jcabi-aether#59. Is this only for linux environment?

@longtimeago
Copy link

I've created an issue for current repository #148
You can read more details about the issue here https://help.github.com/articles/dealing-with-line-endings/

@longtimeago
Copy link

@popprem please, try again. Maybe, you would need to do a fresh clone of repo.
Issue libreio/libre#208 is fixed (at least, PR merged)

@popprem
Copy link
Contributor Author

popprem commented Apr 12, 2015

@davvd Should I try again? issue #46 is not with me currently.

@yegor256
Copy link
Owner

@popprem it's up to you, you won't be paid for it anyway

@popprem popprem closed this Apr 13, 2015
@popprem popprem deleted the 46 branch April 13, 2015 05:00
@popprem
Copy link
Contributor Author

popprem commented Apr 13, 2015

Just to finish up what i did. Please review pull request #169.

@davvd
Copy link

davvd commented Apr 18, 2015

@elenavolokhova please, let us know what do you think about this ticket, according to our QA rules

@elenavolokhova
Copy link

@longtimeago

According to our quality rules:

Messages in a ticket always start with a name of a user they are addressed to.

Some comments are not addressed to anybody:

longtimeago commented 12 days ago
I've created an issue for current repository #148
You can read more details about the issue here https://help.github.com/articles/dealing-with-line-endings/

popprem commented 6 days ago
Just to finish up what i did. Please review pull request #169.

According to our quality rules:

Pull request title explains the problem it is fixing.

There is a not meaningful title.

According to our quality rules:

Pull request description explains the solution proposed and contains a link to the original ticket it is related to.

There is no link to original ticket.

According to our quality rules:

The formatting of a ticket description, as well as all messages inside it, follows Github Markdown style.

I think such logs should use some styling:

popprem commented 12 days ago
.........
[ERROR] \src\test\java\org\takes\http\FtBasicTest.java[92]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)
[ERROR] \src\test\java\org\takes\http\FtBasicTest.java[123]: Lines in file should end with Unix-like end of line (RegexpMultilineCheck)

Please make sure that everyone follows this rule in your tickets in the future.

Please confirm that everything is clear and you have no questions regarding this approach.

@longtimeago
Copy link

@elenavolokhova everything is clear

@elenavolokhova
Copy link

@davvd There were too many issues in this ticket and there was no final solution provided. I think the quality is rather bad here. @yegor256 Please correct me if I'm wrong.

@longtimeago
Copy link

@elenavolokhova PR was closed by reporter. No need to review it's quality

@elenavolokhova
Copy link

@davvd Quality is bad here.

@davvd
Copy link

davvd commented Apr 20, 2015

@davvd Quality is bad here.

@elenavolokhova thanks a lot, noticing bad quality is what makes us better

@davvd
Copy link

davvd commented Apr 24, 2015

@longtimeago I added 10 mins to @elenavolokhova (for QA review) in transaction 55976080

25 mins was added to your account, many thanks for your contribution! The task took 55976118.

you're getting extra minutes here (c=10)

added +25 to your rating, now it is equal to +4649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants