Change cursor based on tool selected #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork with source
|
|
Adds: - View Menu with keyboard shortcuts > Zoom In (+) / Zoom Out (-) - Map ‘+’ cursor drag and move edit mode that can also be toggled with M key
Add map zoom and drag mode
|
Latest commit addresses #51 and #33
Not implemented: scroll wheel zooming in drag mode (but keyboard shortcuts should be sufficient at least for now). |
|
Demo: |
garakmon
commented
Aug 13, 2018
mainwindow.cpp
Outdated
| ui->graphicsView_Objects_Map->scale(0.8,0.8);//scale(0.5,0.5); | ||
| editor->map->scale *= 0.8;//0.5; | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure what a good default value for scaling an image would be. A factor of 2 seems a little high to me but other numbers can get a little wonky when displaying scale.
fixed bug that wouldn’t fig graphicsView_Map to scroll box use exponents rather than what I used before for easier changing of scale factor
|
The icons you're using seem jarring to me because their base coordinate is different. The pencil's is bottom-left, the bucket's is bottom-right, etc. I think this cursor style is easier to use:
|
|
I did it the way I did just because I wanted the tools to work from the tip (like, the pencil shouldn't draw from the middle, etc.), but this is also a good solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve Issue #7 .
*This changes the cursor only over the editable part of the map.