Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Relative paths and useminPrepare #297

Open
buddhike opened this issue Feb 13, 2014 · 4 comments
Open

Relative paths and useminPrepare #297

buddhike opened this issue Feb 13, 2014 · 4 comments
Assignees

Comments

@buddhike
Copy link

In my root directory I have

scripts/this.js
scripts/that.js
foo/index.html

My config is:

'useminPrepare': { 'html': 'foo/index.html'}

index.html has this block

<!-- build:js ../scripts/thisthat.js -->
  <script src="../scripts/this.js"></script>
  <script src="../scripts/that.js"></script>
<!-- endbuild -->

Path generated by useminPrepare for concat is wrong.
expected path:

.tmp/concat/scripts/thisthat.js

actual path:

.tmp/scripts/thisthat.js

I created this unit test. Can someone please confirm if this is a bug?
buddhike@e836c9c

We can workaround the issue using staging option. However, it will not work for us because in our real scenario, html path is not pointing to just one file. we would like to use something like this:

'useminPrepare': { 'html': 'foo/**/index.html'}
buddhike added a commit to buddhike/grunt-usemin that referenced this issue Feb 14, 2014
buddhike added a commit to buddhike/grunt-usemin that referenced this issue Feb 14, 2014
@johannesjo
Copy link

This works nicely and should be merged asap!

buddhike added a commit to buddhike/grunt-usemin that referenced this issue Jun 23, 2014
@DenisMir
Copy link

Why is it still not merged?

buddhike added a commit to buddhike/grunt-usemin that referenced this issue Jul 26, 2014
@brunowego
Copy link

+1

@stephanebachelier stephanebachelier self-assigned this Dec 1, 2014
@stephanebachelier
Copy link
Collaborator

I reopen the issue but as stated by @sindresorhus the PR was closed due to lack of response.
The PR is not complete at this point, I will take a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants