-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blacklist repository is not a real yeoman-generator #484
Conversation
https://www.npmjs.com/package/generator-react-fullstack If you check the code source the repository use yeoman only to copy files of repository https://github.com/kriasoft/react-starter-kit No choice in prompt, no repository on Github. Strange publish @koistya
This looks like a legit case for blacklisting. I haven't personally landed blacklisting items recently so will defer to another member of the team. |
@zckrs have you checked this branch - react-starter-kit/yeoman-generator? It is work in progress though, I'm working on adding prompts and stuff like that to make the yeoman template more customizable. |
It's a bit strange to reference yourself as a generator for a WIP feature in a branch. |
I honestly don't see much problems with a generator which just copies files. It's still more productive if you just need to run What does the rest think? I agree that the generator could use a bunch more features but I don't think this is strictly against our guidelines. Do we even have explicit guidelines for what's a "valid" generator? |
This looks fine by me, plus the author came here to defend his project. As is, I see no reason to blacklist from our search results. |
But the user who clicks on |
@koistya Could you fix the github link of your generator? |
@SBoudrias yep, I will. |
Thanks @koistya |
Still not updated 😞 |
@zckrs if you look at the generator-react-fullstack NPM page, the repository URL is pointing to the right location there. I'm wondering, where does the yeoman.io site is picking repository URL from... Well, if it's absolutely a must to have yeoman generator on the master branch in its own repo separately from the boilerplate project, I would move it to a separate repository, not sure how soon though. |
https://www.npmjs.com/package/generator-react-fullstack
If you check the code source the repository use yeoman only to copy
files of repository https://github.com/kriasoft/react-starter-kit
No choice in prompt, no repository on Github.
Strange publish @koistya