Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist repository is not a real yeoman-generator #484

Closed
wants to merge 1 commit into from
Closed

Blacklist repository is not a real yeoman-generator #484

wants to merge 1 commit into from

Conversation

zckrs
Copy link
Member

@zckrs zckrs commented Jun 26, 2015

https://www.npmjs.com/package/generator-react-fullstack
If you check the code source the repository use yeoman only to copy
files of repository https://github.com/kriasoft/react-starter-kit

No choice in prompt, no repository on Github.
Strange publish @koistya

https://www.npmjs.com/package/generator-react-fullstack
If you check the code source the repository use yeoman only to copy
files of repository https://github.com/kriasoft/react-starter-kit

No choice in prompt, no repository on Github.
Strange publish @koistya
@addyosmani
Copy link
Member

This looks like a legit case for blacklisting. I haven't personally landed blacklisting items recently so will defer to another member of the team.

@koistya
Copy link

koistya commented Jun 27, 2015

No choice in prompt, no repository on Github.

@zckrs have you checked this branch - react-starter-kit/yeoman-generator? It is work in progress though, I'm working on adding prompts and stuff like that to make the yeoman template more customizable.

@zckrs
Copy link
Member Author

zckrs commented Jun 29, 2015

It's a bit strange to reference yourself as a generator for a WIP feature in a branch.

@arthurvr
Copy link
Member

If you check the code source the repository use yeoman only to copy
files of repository https://github.com/kriasoft/react-starter-kit

I honestly don't see much problems with a generator which just copies files. It's still more productive if you just need to run yo whatever to copy the files.

What does the rest think? I agree that the generator could use a bunch more features but I don't think this is strictly against our guidelines.

Do we even have explicit guidelines for what's a "valid" generator?

@SBoudrias
Copy link
Member

This looks fine by me, plus the author came here to defend his project. As is, I see no reason to blacklist from our search results.

@SBoudrias SBoudrias closed this Jun 30, 2015
@zckrs
Copy link
Member Author

zckrs commented Jun 30, 2015

The author came here to defend his project.

But the user who clicks on react-fullstack is redirected to https://github.com/kriasoft/react-starter-kit

@SBoudrias
Copy link
Member

@koistya Could you fix the github link of your generator?

@koistya
Copy link

koistya commented Jun 30, 2015

@SBoudrias yep, I will.

@arthurvr
Copy link
Member

Thanks @koistya

@zckrs
Copy link
Member Author

zckrs commented Jul 9, 2015

Still not updated 😞
Maybe we should add in blacklist then unblacklist when repository is fixed.

@koistya
Copy link

koistya commented Jul 9, 2015

@zckrs if you look at the generator-react-fullstack NPM page, the repository URL is pointing to the right location there. I'm wondering, where does the yeoman.io site is picking repository URL from...

Well, if it's absolutely a must to have yeoman generator on the master branch in its own repo separately from the boilerplate project, I would move it to a separate repository, not sure how soon though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants