Fix upsert SQL to take a list of unique defs #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
force-pushed
the
matt/upsert-sql-uniqs
branch
from
c295f42
to
fc72f34
Compare
4 tasks
parsonsmatt
commented
Apr 16, 2019
| @@ -315,7 +317,7 @@ upsertSql' ent updateVal = T.concat | |||
| , " RETURNING ??" | |||
| ] | |||
| where | |||
| wher = T.intercalate " AND " $ map singleCondition $ entityUniques ent | |||
| wher = T.intercalate " AND " $ map singleCondition $ NEL.toList uniqs | |||
There was a problem hiding this comment.
The issue that prompted this change is documented in #856 . Basically, the type UpsertBy in the tests has two unique defs. The old implementation summoned up all the uniquedefs, and this was OK since the upsert function would blow up at runtime before generating this unless the entity had exactly one unique key.
This change allows the user to provide the unique keys to upsert by. This enables backend-specific upsert-by which should be faster and safer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR: