-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use crypton instead of cryptonite #1838
Conversation
@psibi It looks like you have maintainer rights for both yesod-auth and yesod-static. Would it be possible for you to review this? |
@ysangkok Looks good to me. Can you see why the CI is failing ? |
@psibi Tests are on par with |
@ysangkok It looks like that it would require some changes to |
All versions of crypton contain
So the builds for lts-14 can't use crypton. I see two options:
|
I would lean towards this. CC: @snoyberg if he has any objections. |
Agreed |
yesodweb#1838 will drop support for ghc 8.6
* install stack of macos as it is no longer included ghc 8 not happy no macos-latest nightly (seemingly there to target 9.0) replaced with higher lts versions * update checkout version * no long test on lts-14 #1838 will drop support for ghc 8.6
Cryptonite has been archived on GitHub, and it has been forked to crypton. See
Tested using
This depends on
Before submitting your PR, check that you've:
@since
declarations to the Haddocks for new, public APIsAfter submitting your PR: