Remove context & job agent #2295
Conversation
|
Visit the preview URL for this PR (updated for commit 06b2b55): https://yew-rs--pr2295-remove-context-job-a-mgv273ou.web.app (expires Sun, 02 Jan 2022 14:13:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
We should rename the multi_thread example to either agents or workers. Since all major browsers support WASM Threads, I feel like the title of the example is misleading, considering it doesn't use threads. Pub sub example can also be renamed to contexts (or similar) to better describe what it represents. Also, this seems like a good opportunity to use the new syntax introduced in #2292 in the examples which recently switched to function components. |
Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>
Cargo.toml
Outdated
| "examples/agents", | ||
| "examples/nested_list", | ||
| "examples/node_refs", | ||
| "examples/password_strength", | ||
| "examples/portals", | ||
| "examples/pub_sub", | ||
| "examples/contexts", | ||
| "examples/router", |
There was a problem hiding this comment.
Please sort this alphabetically so it's easier to find members based on the directory structure
| use msg_ctx::MessageProvider; | ||
|
|
||
| #[function_component] | ||
| pub fn Model() -> Html { |
There was a problem hiding this comment.
I would name this App and keep it in a separate app.rs file, but up to you m8 :D
| #[function_component(ShowStorageChanged)] | ||
| pub fn show_storage_changed() -> Html { |
There was a problem hiding this comment.
| #[function_component(ShowStorageChanged)] | |
| pub fn show_storage_changed() -> Html { | |
| #[function_component] | |
| pub fn ShowStorageChanged() -> Html { |
Description
Fixes #2219
Closes #1080
This pull request remove Context and Job agent and replace them with examples in Context API.
Checklist
cargo make pr-flow