feat: iframe accessibility #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## v1.32.0 ### Changes - Support rendering of HTML for richTextV2 and markdown direct answers (#1138)
Iframe needs height in order for map and toggle button to be initialized and to fill js-answersMap
Fix iframe Answers Map/List toggle button on Mobile Error
EmilyZhang777
previously approved these changes
Oct 23, 2023
Iframe needs height in order for map and toggle button to be initialized and to fill js-answersMap
benmcginnis
force-pushed
the
feature/iframe-wcag
branch
from
797d534
to
1263d53
Compare
nmanu1
reviewed
Dec 4, 2023
This change udpates the iframe-common script to set several important attributes for screen reader's to properly interpret the presence of the iframe. The attributes do the following things: * ariaBusy (aria-busy): notifies the screen reader that the iframe is loading * role=document: tells screen readers to treat the frame contents as a document * aria-live=assertive: tells screen readers to immediately read the frame content * tabindex=0: tabindex is required on document roles to ensure that it is treated as keyboard accessible J=TECHOPS-10193 TEST=manual Manually tested using both Mac VoiceOver and Windows Narrator and validated that the results were read by the screen reader.
benmcginnis
force-pushed
the
feature/iframe-wcag
branch
from
1263d53
to
2b27c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change udpates the iframe-common script to set several important attributes for screen reader's to properly interpret the presence of the iframe.
The attributes do the following things:
J=TECHOPS-10193
TEST=manual
Manually tested using both Mac VoiceOver and Windows Narrator and validated that the results were read by the screen reader.